Re: [PATCH 1/3] Testing: XDG config files: Export a suitable `XDG_CONFIG_HOME' environment variable

Matthieu Moy writes: > Before your patches, the correct management of $XDG_CONFIG_HOME to > override $HOME/.config/git/ was untested (which is unfortunate, indeed), > but after your patch serie, the fact that the default is > $HOME/.config/git/ is untested, which IMHO is even worse. > > Unsetting

Re: [PATCH 1/3] Testing: XDG config files: Export a suitable `XDG_CONFIG_HOME' environment variable

Michael Witten writes: > --- a/t/test-lib.sh > +++ b/t/test-lib.sh > @@ -544,6 +544,9 @@ rm -fr "$test" || { > HOME="$TRASH_DIRECTORY" > export HOME > > +XDG_CONFIG_HOME=$HOME/.config > +export XDG_CONFIG_HOME > + Why not just unset XDG_CONFIG_HOME? Your match makes it look like XDG_CONFIG_

Re: [PATCH 1/3] Testing: XDG config files: Export a suitable `XDG_CONFIG_HOME' environment variable

Hi, Michael Witten wrote: > --- a/t/test-lib.sh > +++ b/t/test-lib.sh > @@ -544,6 +544,9 @@ rm -fr "$test" || { > HOME="$TRASH_DIRECTORY" > export HOME > > +XDG_CONFIG_HOME=$HOME/.config > +export XDG_CONFIG_HOME > + I think this is a bad idea. The typical case is for XDG_CONFIG_HOME not to

[PATCH 1/3] Testing: XDG config files: Export a suitable `XDG_CONFIG_HOME' environment variable

The tests in: t/t1306-xdg-files.sh were failing because the git commands were using the environment variable `XDG_CONFIG_HOME' as it was set for the user's usual environment, rather than as set for the testing environment. This commit provides the quickest, simplest hack to make things work; b