Re: [PATCH 1/3] read-cache: use shared perms when writing shared index

On Thu, 22 Jun 2017 12:51:54 -0700 Junio wrote: > > Let's fix that by using create_tempfile() instead of mks_tempfile() > > to create the shared index file. > > > > ... > > - fd = mks_tempfile(_sharedindex, > > git_path("sharedindex_XX")); > > + fd = create_tempfile(_sharedindex,

Re: [PATCH 1/3] read-cache: use shared perms when writing shared index

On Thu, Jun 22, 2017 at 9:51 PM, Junio C Hamano wrote: > Christian Couder writes: >> Let's fix that by using create_tempfile() instead of mks_tempfile() >> to create the shared index file. >> >> ... >> - fd = mks_tempfile(_sharedindex, >>

Re: [PATCH 1/3] read-cache: use shared perms when writing shared index

Christian Couder writes: > Since f6ecc62dbf (write_shared_index(): use tempfile module, 2015-08-10) > write_shared_index() has been using mks_tempfile() to create the > temporary file that will become the shared index. > > But even before that, it looks like the

[PATCH 1/3] read-cache: use shared perms when writing shared index

Since f6ecc62dbf (write_shared_index(): use tempfile module, 2015-08-10) write_shared_index() has been using mks_tempfile() to create the temporary file that will become the shared index. But even before that, it looks like the functions used to create this file didn't call adjust_shared_perm(),