Re: [PATCH 1/3] t7001: reformat to newer style

2018-09-25 Thread Junio C Hamano
Stefan Beller writes: > Heh, thanks for calling that out. So we're looking at a full formatter > instead of a partial formatter that helps moving in the right direction now. > :-/ The parts left out of these patches (e.g. use subshell when working in a subdirectory) need human decision and a

Re: [PATCH 1/3] t7001: reformat to newer style

2018-09-24 Thread Stefan Beller
On Mon, Sep 24, 2018 at 6:31 AM Derrick Stolee wrote: > > On 9/21/2018 7:58 PM, Stefan Beller wrote: > > The old formatting style is a real hindrance of getting people up to speed > > contributing as they use existing code as an example and follow that style. > > So let's get rid of the old style

Re: [PATCH 1/3] t7001: reformat to newer style

2018-09-24 Thread Junio C Hamano
Derrick Stolee writes: >> +test_expect_success 'moving the file back into subdirectory' ' >> +cd path0 && git mv ../path1/COPYING COPYING >> +' > > Split at &&, use subshell? Yes, I was almost going to point out the same, saying "'reformat to newer style' is much larger than only changing

Re: [PATCH 1/3] t7001: reformat to newer style

2018-09-24 Thread Derrick Stolee
On 9/21/2018 7:58 PM, Stefan Beller wrote: The old formatting style is a real hindrance of getting people up to speed contributing as they use existing code as an example and follow that style. So let's get rid of the old style and reformat it in our current style. I was suspicious of your

[PATCH 1/3] t7001: reformat to newer style

2018-09-21 Thread Stefan Beller
The old formatting style is a real hindrance of getting people up to speed contributing as they use existing code as an example and follow that style. So let's get rid of the old style and reformat it in our current style. Reported-by: Derrick Stolee Reported-by: Jeff Hostetler Signed-off-by: