Re: [PATCH 1/4] bisect--helper: `bisect_clean_state` shell function in C

2016-06-08 Thread Pranit Bauva
Hey Eric, On Wed, Jun 8, 2016 at 11:29 PM, Eric Sunshine wrote: > On Wed, Jun 8, 2016 at 5:41 AM, Christian Couder > wrote: >> On Wed, Jun 8, 2016 at 10:02 AM, Eric Sunshine >> wrote: >>> On Wed, Jun 8, 2016 at 3:46

Re: [PATCH 1/4] bisect--helper: `bisect_clean_state` shell function in C

2016-06-08 Thread Eric Sunshine
On Wed, Jun 8, 2016 at 5:41 AM, Christian Couder wrote: > On Wed, Jun 8, 2016 at 10:02 AM, Eric Sunshine > wrote: >> On Wed, Jun 8, 2016 at 3:46 AM, Pranit Bauva wrote: >>> On Wed, Jun 8, 2016 at 4:01 AM, Eric

Re: [PATCH 1/4] bisect--helper: `bisect_clean_state` shell function in C

2016-06-08 Thread Christian Couder
On Wed, Jun 8, 2016 at 10:02 AM, Eric Sunshine wrote: > On Wed, Jun 8, 2016 at 3:46 AM, Pranit Bauva wrote: >> On Wed, Jun 8, 2016 at 4:01 AM, Eric Sunshine >> wrote: >>> On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva

Re: [PATCH 1/4] bisect--helper: `bisect_clean_state` shell function in C

2016-06-08 Thread Pranit Bauva
Hey Eric, On Wed, Jun 8, 2016 at 1:32 PM, Eric Sunshine wrote: > On Wed, Jun 8, 2016 at 3:46 AM, Pranit Bauva wrote: >> On Wed, Jun 8, 2016 at 4:01 AM, Eric Sunshine >> wrote: >>> On Tue, Jun 7, 2016 at 4:54 PM, Pranit

Re: [PATCH 1/4] bisect--helper: `bisect_clean_state` shell function in C

2016-06-08 Thread Eric Sunshine
On Wed, Jun 8, 2016 at 3:46 AM, Pranit Bauva wrote: > On Wed, Jun 8, 2016 at 4:01 AM, Eric Sunshine wrote: >> On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote: >>> + struct string_list *refs = cb_data; >>> +

Re: [PATCH 1/4] bisect--helper: `bisect_clean_state` shell function in C

2016-06-08 Thread Pranit Bauva
Hey Eric, On Wed, Jun 8, 2016 at 4:01 AM, Eric Sunshine wrote: > On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote: >> Reimplement `bisect_clean_state` shell function in C and add a >> `bisect-clean-state` subcommand to `git bisect--helper` to

Re: [PATCH 1/4] bisect--helper: `bisect_clean_state` shell function in C

2016-06-07 Thread Eric Sunshine
On Tue, Jun 7, 2016 at 6:31 PM, Eric Sunshine wrote: > On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote: >> +int bisect_clean_state(void) >> +{ I forgot to mention that this and other functions should be 'static'. >> + int result = 0; >>

Re: [PATCH 1/4] bisect--helper: `bisect_clean_state` shell function in C

2016-06-07 Thread Eric Sunshine
On Tue, Jun 7, 2016 at 4:54 PM, Pranit Bauva wrote: > Reimplement `bisect_clean_state` shell function in C and add a > `bisect-clean-state` subcommand to `git bisect--helper` to call it from > git-bisect.sh . > [...] > Signed-off-by: Pranit Bauva >

[PATCH 1/4] bisect--helper: `bisect_clean_state` shell function in C

2016-06-07 Thread Pranit Bauva
Reimplement `bisect_clean_state` shell function in C and add a `bisect-clean-state` subcommand to `git bisect--helper` to call it from git-bisect.sh . Using `bisect_clean_state` subcommand is a measure to port shell function to C so as to use the existing test suite. As more functions are ported,