Re: [PATCH 1/4] builtin/interpret-trailers.c: allow -t

"Michael S. Tsirkin" writes: > Aren't there other cases where a short option needs to be > converted to a long one? As I already said, making internal call to libified part (perhaps in trailer.c) would make this part of conversation a moot point, but in general you can find

Re: [PATCH 1/4] builtin/interpret-trailers.c: allow -t

On Thu, Apr 07, 2016 at 10:30:02AM -0700, Junio C Hamano wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Apr 07, 2016 at 09:55:29AM -0700, Junio C Hamano wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > Allow -t as a short-cut for --trailer. > >> > >

Re: [PATCH 1/4] builtin/interpret-trailers.c: allow -t

On Thu, Apr 07, 2016 at 10:26:33AM -0700, Junio C Hamano wrote: > Matthieu Moy writes: > > >> I am in principle OK with the later step that teaches a single > >> letter option to end-user facing "git am" that would be turned into > >> "--trailer" when it calls out

Re: [PATCH 1/4] builtin/interpret-trailers.c: allow -t

"Michael S. Tsirkin" writes: > On Thu, Apr 07, 2016 at 09:55:29AM -0700, Junio C Hamano wrote: >> "Michael S. Tsirkin" writes: >> >> > Allow -t as a short-cut for --trailer. >> > >> > Signed-off-by: Michael S. Tsirkin >> > --- >> >> As I do

Re: [PATCH 1/4] builtin/interpret-trailers.c: allow -t

On Thu, Apr 07, 2016 at 09:55:29AM -0700, Junio C Hamano wrote: > "Michael S. Tsirkin" writes: > > > Allow -t as a short-cut for --trailer. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > As I do not think interpret-trailers is meant to be end-user

Re: [PATCH 1/4] builtin/interpret-trailers.c: allow -t

Matthieu Moy writes: >> I am in principle OK with the later step that teaches a single >> letter option to end-user facing "git am" that would be turned into >> "--trailer" when it calls out to "interpret-trailers" (I haven't >> checked if 't' is a sensible choice

Re: [PATCH 1/4] builtin/interpret-trailers.c: allow -t

Junio C Hamano writes: > "Michael S. Tsirkin" writes: > >> Allow -t as a short-cut for --trailer. >> >> Signed-off-by: Michael S. Tsirkin >> --- > > As I do not think interpret-trailers is meant to be end-user facing, > I am not sure I

Re: [PATCH 1/4] builtin/interpret-trailers.c: allow -t

"Michael S. Tsirkin" writes: > Allow -t as a short-cut for --trailer. > > Signed-off-by: Michael S. Tsirkin > --- As I do not think interpret-trailers is meant to be end-user facing, I am not sure I should be interested in this step. I am in principle OK with

[PATCH 1/4] builtin/interpret-trailers.c: allow -t

Allow -t as a short-cut for --trailer. Signed-off-by: Michael S. Tsirkin --- builtin/interpret-trailers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/interpret-trailers.c b/builtin/interpret-trailers.c index b99ae4b..18cf640 100644 ---