Re: [PATCH 1/6] add, update-index: fix --chmod argument help

2018-08-02 Thread Junio C Hamano
Ramsay Jones writes: >> OPT_BOOL( 0 , "ignore-missing", &ignore_missing, N_("check if - even >> missing - files are ignored in dry run")), >> -OPT_STRING( 0 , "chmod", &chmod_arg, N_("(+/-)x"), N_("override the >> executable bit of the listed files")), >> +{ OPTION_STRING, 0, "chmo

Re: [PATCH 1/6] add, update-index: fix --chmod argument help

2018-08-02 Thread Junio C Hamano
Andrei Rybak writes: > On 2018-08-02 21:17, René Scharfe wrote: >> Don't translate the argument specification for --chmod; "+x" and "-x" >> are the literal strings that the commands accept. >> > [...] >> >> -OPT_STRING( 0 , "chmod", &chmod_arg, N_("(+/-)x"), N_("override the >> executable b

Re: [PATCH 1/6] add, update-index: fix --chmod argument help

2018-08-02 Thread Andrei Rybak
On 2018-08-02 21:17, René Scharfe wrote: > Don't translate the argument specification for --chmod; "+x" and "-x" > are the literal strings that the commands accept. > > [...] > > - OPT_STRING( 0 , "chmod", &chmod_arg, N_("(+/-)x"), N_("override the > executable bit of the listed files")), > +

Re: [PATCH 1/6] add, update-index: fix --chmod argument help

2018-08-02 Thread Ramsay Jones
On 02/08/18 20:17, René Scharfe wrote: > Don't translate the argument specification for --chmod; "+x" and "-x" > are the literal strings that the commands accept. > > Separate alternatives using a pipe character instead of a slash, for > consistency. > > Use the flag PARSE_OPT_LITERAL_ARGHELP

Re: [PATCH 1/6] add, update-index: fix --chmod argument help

2018-08-02 Thread Ævar Arnfjörð Bjarmason
On Thu, Aug 02 2018, René Scharfe wrote: > Don't translate the argument specification for --chmod; "+x" and "-x" > are the literal strings that the commands accept. > > Separate alternatives using a pipe character instead of a slash, for > consistency. > > Use the flag PARSE_OPT_LITERAL_ARGHELP

[PATCH 1/6] add, update-index: fix --chmod argument help

2018-08-02 Thread René Scharfe
Don't translate the argument specification for --chmod; "+x" and "-x" are the literal strings that the commands accept. Separate alternatives using a pipe character instead of a slash, for consistency. Use the flag PARSE_OPT_LITERAL_ARGHELP to prevent parseopt from adding a pair of angular bracke