Re: [PATCH 1/8] write_ref_sha1(): remove check for lock == NULL

On Mon, Feb 9, 2015 at 1:12 AM, Michael Haggerty mhag...@alum.mit.edu wrote: None of the callers pass NULL to this function, and there doesn't seem to be any usefulness to allowing them to do so. Usually I'd oppose this change, as it seems to be a good defensive measure. (I cannot assume future

Re: [PATCH 1/8] write_ref_sha1(): remove check for lock == NULL

On Tue, Feb 10, 2015 at 02:52:23PM -0800, Stefan Beller wrote: On Mon, Feb 9, 2015 at 1:12 AM, Michael Haggerty mhag...@alum.mit.edu wrote: None of the callers pass NULL to this function, and there doesn't seem to be any usefulness to allowing them to do so. Usually I'd oppose this

[PATCH 1/8] write_ref_sha1(): remove check for lock == NULL

None of the callers pass NULL to this function, and there doesn't seem to be any usefulness to allowing them to do so. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu --- refs.c | 4 1 file changed, 4 deletions(-) diff --git a/refs.c b/refs.c index c5fa709..d1130e2 100644 --- a/refs.c