Re: [PATCH 10/33] refs: extract a function ref_resolves_to_object()

2013-04-16 Thread Junio C Hamano
Michael Haggerty writes: > In projects where I can choose the coding standard, I like to use extra > whitespace to help the eye pick out the range of parentheses, like > > if (!( > (flags & DO_FOR_EACH_INCLUDE_BROKEN) || > ref_resolves_to_object(entry) >

Re: [PATCH 10/33] refs: extract a function ref_resolves_to_object()

2013-04-16 Thread Michael Haggerty
On 04/15/2013 06:51 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> It is a nice unit of work and soon will be needed from multiple >> locations. >> >> Signed-off-by: Michael Haggerty >> --- >> refs.c | 28 >> 1 file changed, 20 insertions(+), 8 deletions(

Re: [PATCH 10/33] refs: extract a function ref_resolves_to_object()

2013-04-15 Thread Junio C Hamano
Michael Haggerty writes: > It is a nice unit of work and soon will be needed from multiple > locations. > > Signed-off-by: Michael Haggerty > --- > refs.c | 28 > 1 file changed, 20 insertions(+), 8 deletions(-) > > diff --git a/refs.c b/refs.c > index c523978..dfc8

[PATCH 10/33] refs: extract a function ref_resolves_to_object()

2013-04-14 Thread Michael Haggerty
It is a nice unit of work and soon will be needed from multiple locations. Signed-off-by: Michael Haggerty --- refs.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/refs.c b/refs.c index c523978..dfc8600 100644 --- a/refs.c +++ b/refs.c @@ -529,