Re: [PATCH 12/12] fsck: mark strings for translation

2018-11-05 Thread Duy Nguyen
On Mon, Oct 29, 2018 at 12:53 PM SZEDER Gábor wrote: > The contents of 'out': > > broken link fromtree be45bbd3809e0829297cefa576e699c134abacfd > (refs/heads/master@{1112912113}:caesar.t) > toblob be45bbd3809e0829297cefa576e699c134abacfd >

Re: [PATCH 12/12] fsck: mark strings for translation

2018-10-31 Thread Jiang Xin
Ævar Arnfjörð Bjarmason 于2018年10月30日周二 上午1:43写道： > On Mon, Oct 29 2018, Ævar Arnfjörð Bjarmason wrote: > Unlike the rest of our stack where we need to support however many years > old tools we can freely rely on bleeding-edge gettext features, since > the only person we need to convince to

Re: [PATCH 12/12] fsck: mark strings for translation

2018-10-30 Thread Jonathan Nieder
Hi, Ævar Arnfjörð Bjarmason wrote: >> On Mon, Oct 29, 2018 at 3:09 PM Junio C Hamano wrote: >>> SZEDER Gábor writes: Nguyễn Thái Ngọc Duy wrote: > -fprintf(stderr, "%s in %s %s: %s\n", > -msg_type, printable_type(obj), describe_object(obj), err); > +

Re: [PATCH 12/12] fsck: mark strings for translation

2018-10-29 Thread Ævar Arnfjörð Bjarmason
On Mon, Oct 29 2018, Ævar Arnfjörð Bjarmason wrote: > On Mon, Oct 29 2018, Duy Nguyen wrote: > >> On Mon, Oct 29, 2018 at 3:09 PM Junio C Hamano wrote: >>> >>> SZEDER Gábor writes: >>> >>> >> -fprintf(stderr, "%s in %s %s: %s\n", >>> >> -msg_type, printable_type(obj),

Re: [PATCH 12/12] fsck: mark strings for translation

2018-10-29 Thread Ævar Arnfjörð Bjarmason
On Mon, Oct 29 2018, Duy Nguyen wrote: > On Mon, Oct 29, 2018 at 3:09 PM Junio C Hamano wrote: >> >> SZEDER Gábor writes: >> >> >> -fprintf(stderr, "%s in %s %s: %s\n", >> >> -msg_type, printable_type(obj), describe_object(obj), err); >> >> +fprintf_ln(stderr, _("%s in %s

Re: [PATCH 12/12] fsck: mark strings for translation

2018-10-29 Thread Duy Nguyen
On Mon, Oct 29, 2018 at 3:09 PM Junio C Hamano wrote: > > SZEDER Gábor writes: > > >> -fprintf(stderr, "%s in %s %s: %s\n", > >> -msg_type, printable_type(obj), describe_object(obj), err); > >> +fprintf_ln(stderr, _("%s in %s %s: %s"), > > > > Are the (f)printf() ->

Re: [PATCH 12/12] fsck: mark strings for translation

2018-10-29 Thread Junio C Hamano
SZEDER Gábor writes: >> -fprintf(stderr, "%s in %s %s: %s\n", >> -msg_type, printable_type(obj), describe_object(obj), err); >> +fprintf_ln(stderr, _("%s in %s %s: %s"), > > Are the (f)printf() -> (f)printf_ln() changes all over > 'builtin/fsck.c' really necessary to mark

Re: [PATCH 12/12] fsck: mark strings for translation

2018-10-29 Thread SZEDER Gábor
On Sun, Oct 28, 2018 at 07:51:57AM +0100, Nguyễn Thái Ngọc Duy wrote: > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > builtin/fsck.c | 113 - > t/t1410-reflog.sh | 6 +- > t/t1450-fsck.sh| 50 >

[PATCH 12/12] fsck: mark strings for translation

2018-10-28 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/fsck.c | 113 - t/t1410-reflog.sh | 6 +- t/t1450-fsck.sh| 50 t/t6050-replace.sh | 4 +- t/t7415-submodule-names.sh | 6 +- 5 files changed, 94