[PATCH 13/13] move LESS/LV pager environment to Makefile

2014-02-05 Thread Jeff King
We set the LESS and LV variables to sensible defaults if they are not already set. However, the code is brittle. There is no easy way to change the defaults at compile time, and we have to duplicate the code in git-sh-setup and in pager.c. Let's turn it into a normal Makefile knob instead.

Re: [PATCH 13/13] move LESS/LV pager environment to Makefile

2014-02-05 Thread Jeff King
On Wed, Feb 05, 2014 at 01:08:57PM -0500, Jeff King wrote: +quote() { + echo $1 | sed 's/\\//g; s//\\/' +} This of course has the same /g bug as the earlier patch in the series. I was tempted to pull the function out into script/lib-c.sh, so that both can source it, but perhaps that

Re: [PATCH 13/13] move LESS/LV pager environment to Makefile

2014-02-05 Thread Jeff King
On Wed, Feb 05, 2014 at 02:23:50PM -0500, Jeff King wrote: On Wed, Feb 05, 2014 at 01:08:57PM -0500, Jeff King wrote: +quote() { + echo $1 | sed 's/\\//g; s//\\/' +} This of course has the same /g bug as the earlier patch in the series. I was tempted to pull the function out