Re: [PATCH 15/33] refs: change the internal reference-iteration API

2013-04-16 Thread Junio C Hamano
Michael Haggerty writes: >>> ... This scenario doesn't currently occur in the code, >>> but fix it to prevent things from breaking in a very confusing way in >>> the future. >> >> Hopefully that means "in later patches in this series" ;-) > > I don't think that the rest of the series would have

Re: [PATCH 15/33] refs: change the internal reference-iteration API

2013-04-16 Thread Michael Haggerty
On 04/15/2013 07:38 PM, Junio C Hamano wrote: > Michael Haggerty writes: >> [...] But more >> importantly, this change prevents peel_ref() from returning invalid >> results in the following scenario: >> >> When iterating via the external API, the iteration always includes >> both packed and loose

Re: [PATCH 15/33] refs: change the internal reference-iteration API

2013-04-15 Thread Junio C Hamano
Michael Haggerty writes: > Establish an internal API for iterating over references, which gives > the callback functions direct access to the ref_entry structure > describing the reference. (Do not change the iteration API that is > exposed outside of the module.) > > Define a new internal callb

[PATCH 15/33] refs: change the internal reference-iteration API

2013-04-14 Thread Michael Haggerty
Establish an internal API for iterating over references, which gives the callback functions direct access to the ref_entry structure describing the reference. (Do not change the iteration API that is exposed outside of the module.) Define a new internal callback signature int each_ref_entry_f