Re: [PATCH 16/18] receive-pack: GPG-validate push certificates

2014-08-21 Thread Junio C Hamano
If you ignore the clock skew between the pusher and the receiver, then you are correct, but otherwise not quite. Also by specifying that as , not , the receiving end has a choice in how to generate and use the nonce value. The only requirement on the protocol is that the pusher must parrot it lite

Re: [PATCH 16/18] receive-pack: GPG-validate push certificates

2014-08-21 Thread David Turner
On Wed, 2014-08-20 at 12:38 -0700, Junio C Hamano wrote: > David Turner writes: > > > On Wed, 2014-08-20 at 10:29 -0700, Junio C Hamano wrote: > >> On Wed, Aug 20, 2014 at 9:56 AM, David Turner > >> wrote: > >> > On Tue, 2014-08-19 at 15:06 -0700, Junio C Hamano wrote: > >> >> Reusing the GPG s

Re: [PATCH 16/18] receive-pack: GPG-validate push certificates

2014-08-20 Thread Junio C Hamano
David Turner writes: > On Wed, 2014-08-20 at 10:29 -0700, Junio C Hamano wrote: >> On Wed, Aug 20, 2014 at 9:56 AM, David Turner >> wrote: >> > On Tue, 2014-08-19 at 15:06 -0700, Junio C Hamano wrote: >> >> Reusing the GPG signature check helpers we already have, verify >> >> the signature in r

Re: [PATCH 16/18] receive-pack: GPG-validate push certificates

2014-08-20 Thread David Turner
On Wed, 2014-08-20 at 10:29 -0700, Junio C Hamano wrote: > On Wed, Aug 20, 2014 at 9:56 AM, David Turner > wrote: > > On Tue, 2014-08-19 at 15:06 -0700, Junio C Hamano wrote: > >> Reusing the GPG signature check helpers we already have, verify > >> the signature in receive-pack and give the resul

Re: [PATCH 16/18] receive-pack: GPG-validate push certificates

2014-08-20 Thread Junio C Hamano
On Wed, Aug 20, 2014 at 9:56 AM, David Turner wrote: > On Tue, 2014-08-19 at 15:06 -0700, Junio C Hamano wrote: >> Reusing the GPG signature check helpers we already have, verify >> the signature in receive-pack and give the results to the hooks >> via GIT_PUSH_CERT_{SIGNER,KEY,STATUS} environment

Re: [PATCH 16/18] receive-pack: GPG-validate push certificates

2014-08-20 Thread David Turner
On Tue, 2014-08-19 at 15:06 -0700, Junio C Hamano wrote: > Reusing the GPG signature check helpers we already have, verify > the signature in receive-pack and give the results to the hooks > via GIT_PUSH_CERT_{SIGNER,KEY,STATUS} environment variables. > > Policy decisions, such as accepting or rej

[PATCH 16/18] receive-pack: GPG-validate push certificates

2014-08-19 Thread Junio C Hamano
Reusing the GPG signature check helpers we already have, verify the signature in receive-pack and give the results to the hooks via GIT_PUSH_CERT_{SIGNER,KEY,STATUS} environment variables. Policy decisions, such as accepting or rejecting a good signature by a key that is not fully trusted, is left