Re: [PATCH 18/19] index-helper: autorun

2016-03-20 Thread Johannes Schindelin
Hi Duy, On Fri, 18 Mar 2016, Duy Nguyen wrote: > On Thu, Mar 17, 2016 at 9:43 PM, Johannes Schindelin > wrote: > > > I know of use cases where the index weighs 300MB, and falling back to > > reading it directly *really* hurts. > > For crying out loud, what do you

Re: [PATCH 18/19] index-helper: autorun

2016-03-19 Thread Duy Nguyen
On Sat, Mar 19, 2016 at 12:22 AM, David Turner wrote: > On Fri, 2016-03-18 at 14:44 +0700, Duy Nguyen wrote: >> > So yeah, this is the challenge: to make Git work at real-world >> > scale >> > (didn't we hear a lot about this at the latest Git Merge?) >> >> I'm all for

Re: [PATCH 18/19] index-helper: autorun

2016-03-19 Thread David Turner
On Thu, 2016-03-17 at 15:43 +0100, Johannes Schindelin wrote: > Hi Duy, > > On Thu, 17 Mar 2016, Duy Nguyen wrote: > > > On Thu, Mar 17, 2016 at 1:27 AM, Johannes Schindelin > > wrote: > > > I am much more concerned about concurrent accesses and the > > >

Re: [PATCH 18/19] index-helper: autorun

2016-03-19 Thread Duy Nguyen
On Tue, Mar 15, 2016 at 9:26 PM, Johannes Schindelin wrote: > Hi Duy, > > On Tue, 15 Mar 2016, Duy Nguyen wrote: > >> On Thu, Mar 10, 2016 at 1:36 AM, David Turner >> wrote: >> > Introduce a new config option, indexhelper.autorun, to

Re: [PATCH 18/19] index-helper: autorun

2016-03-19 Thread Johannes Schindelin
Hi Duy, On Thu, 17 Mar 2016, Duy Nguyen wrote: > On Thu, Mar 17, 2016 at 1:27 AM, Johannes Schindelin > wrote: > > I am much more concerned about concurrent accesses and the communication > > between the Git processes and the index-helper. Writing to the .pid file >

Re: [PATCH 18/19] index-helper: autorun

2016-03-19 Thread David Turner
On Fri, 2016-03-18 at 14:44 +0700, Duy Nguyen wrote: > > So yeah, this is the challenge: to make Git work at real-world > > scale > > (didn't we hear a lot about this at the latest Git Merge?) > > I'm all for making Junio cry by using Git for what it is (or was) not > intended for, but this seems

Re: [PATCH 18/19] index-helper: autorun

2016-03-19 Thread Johannes Schindelin
Hi David, On Wed, 16 Mar 2016, David Turner wrote: > I don't understand what a "detached process" is on Windows (I have never > done any real Windows programming). Does that mean "call daemonize() and > it'll take care of it?" Or something else? Or should I just not worry > about it and let

Re: [PATCH 18/19] index-helper: autorun

2016-03-19 Thread Duy Nguyen
On Fri, Mar 18, 2016 at 2:17 PM, Johannes Schindelin wrote: > Hi Duy, > > On Fri, 18 Mar 2016, Duy Nguyen wrote: > >> > Well, the way I read the code it is possible that: >> > >> > 1. Git process 1 starts, reading the index >> > 2. Git process 2 starts, poking the

Re: [PATCH 18/19] index-helper: autorun

2016-03-19 Thread Duy Nguyen
On Fri, Mar 18, 2016 at 2:14 PM, Johannes Schindelin wrote: > Hi Duy, > > On Fri, 18 Mar 2016, Duy Nguyen wrote: > >> On Thu, Mar 17, 2016 at 9:43 PM, Johannes Schindelin >> wrote: >> >> > I know of use cases where the index weighs 300MB,

Re: [PATCH 18/19] index-helper: autorun

2016-03-19 Thread Johannes Schindelin
Hi Duy, On Fri, 18 Mar 2016, Duy Nguyen wrote: > On Fri, Mar 18, 2016 at 2:17 PM, Johannes Schindelin > wrote: > > > > On Fri, 18 Mar 2016, Duy Nguyen wrote: > > > >> > Well, the way I read the code it is possible that: > >> > > >> > 1. Git process 1 starts, reading

Re: [PATCH 18/19] index-helper: autorun

2016-03-19 Thread David Turner
On Tue, 2016-03-15 at 15:26 +0100, Johannes Schindelin wrote: > Hi Duy, > > On Tue, 15 Mar 2016, Duy Nguyen wrote: > > > On Thu, Mar 10, 2016 at 1:36 AM, David Turner < > > dtur...@twopensource.com> wrote: > > > Introduce a new config option, indexhelper.autorun, to > > > automatically > > > run

Re: [PATCH 18/19] index-helper: autorun

2016-03-18 Thread Johannes Schindelin
Hi Duy, On Fri, 18 Mar 2016, Duy Nguyen wrote: > > Well, the way I read the code it is possible that: > > > > 1. Git process 1 starts, reading the index > > 2. Git process 2 starts, poking the index-helper > > 3. The index-helper updates the .pid file (why not set a bit in the shared > >

Re: [PATCH 18/19] index-helper: autorun

2016-03-18 Thread Duy Nguyen
On Thu, Mar 17, 2016 at 1:27 AM, Johannes Schindelin wrote: > I am much more concerned about concurrent accesses and the communication > between the Git processes and the index-helper. Writing to the .pid file > sounds very fragile to me, in particular when multiple

Re: [PATCH 18/19] index-helper: autorun

2016-03-18 Thread Duy Nguyen
On Thu, Mar 17, 2016 at 9:43 PM, Johannes Schindelin wrote: > Hi Duy, > > On Thu, 17 Mar 2016, Duy Nguyen wrote: > >> On Thu, Mar 17, 2016 at 1:27 AM, Johannes Schindelin >> wrote: >> > I am much more concerned about concurrent accesses and

Re: [PATCH 18/19] index-helper: autorun

2016-03-15 Thread Johannes Schindelin
Hi Duy, On Tue, 15 Mar 2016, Duy Nguyen wrote: > On Thu, Mar 10, 2016 at 1:36 AM, David Turner > wrote: > > Introduce a new config option, indexhelper.autorun, to automatically > > run git index-helper before starting up a builtin git command. This > > enables users

Re: [PATCH 18/19] index-helper: autorun

2016-03-15 Thread Duy Nguyen
On Thu, Mar 10, 2016 at 1:36 AM, David Turner wrote: > Introduce a new config option, indexhelper.autorun, to automatically > run git index-helper before starting up a builtin git command. This > enables users to keep index-helper running without manual > intervention.

[PATCH 18/19] index-helper: autorun

2016-03-09 Thread David Turner
Introduce a new config option, indexhelper.autorun, to automatically run git index-helper before starting up a builtin git command. This enables users to keep index-helper running without manual intervention. Signed-off-by: David Turner --- git.c |