Re: [PATCH 18/29] grep: catch a missing enum in switch statement

On Thu, May 11, 2017 at 10:40 PM, Stefan Beller wrote: > On Thu, May 11, 2017 at 1:08 PM, Brandon Williams wrote: >> On 05/11, Ævar Arnfjörð Bjarmason wrote: >>> Add a die(...) to a default case for the switch statement selecting >>> between grep pattern

Re: [PATCH 18/29] grep: catch a missing enum in switch statement

On Thu, May 11, 2017 at 1:08 PM, Brandon Williams wrote: > On 05/11, Ævar Arnfjörð Bjarmason wrote: >> Add a die(...) to a default case for the switch statement selecting >> between grep pattern types under --recurse-submodules. >> >> Normally this would be caught by -Wswitch,

Re: [PATCH 18/29] grep: catch a missing enum in switch statement

On 05/11, Ævar Arnfjörð Bjarmason wrote: > Add a die(...) to a default case for the switch statement selecting > between grep pattern types under --recurse-submodules. > > Normally this would be caught by -Wswitch, but the grep_pattern_type > type is converted to int by going through

[PATCH 18/29] grep: catch a missing enum in switch statement

Add a die(...) to a default case for the switch statement selecting between grep pattern types under --recurse-submodules. Normally this would be caught by -Wswitch, but the grep_pattern_type type is converted to int by going through parse_options(). Changing the argument type passed to