Re: [PATCH 19/19] hack: watchman/untracked cache mashup

2016-03-19 Thread David Turner
On Thu, 2016-03-17 at 20:06 +0700, Duy Nguyen wrote: > On Thu, Mar 17, 2016 at 7:56 AM, David Turner < > dtur...@twopensource.com> wrote: > > > So if we detect an updated file that's not in the index, we are > > > prepared to invalidate that path, correct? We may invalidate more > > > than > > >

Re: [PATCH 19/19] hack: watchman/untracked cache mashup

2016-03-19 Thread Duy Nguyen
On Thu, Mar 17, 2016 at 7:56 AM, David Turner wrote: >> So if we detect an updated file that's not in the index, we are >> prepared to invalidate that path, correct? We may invalidate more >> than >> necessary if that's true. Imagine a.o is already ignored. If it's >>

Re: [PATCH 19/19] hack: watchman/untracked cache mashup

2016-03-19 Thread David Turner
On Tue, 2016-03-15 at 19:31 +0700, Duy Nguyen wrote: > On Thu, Mar 10, 2016 at 1:36 AM, David Turner < > dtur...@twopensource.com> wrote: > > static struct watchman_query *make_query(const char *last_update) > > @@ -60,8 +61,24 @@ static void update_index(struct index_state > > *istate, > >

Re: [PATCH 19/19] hack: watchman/untracked cache mashup

2016-03-15 Thread Duy Nguyen
On Thu, Mar 10, 2016 at 1:36 AM, David Turner wrote: > static struct watchman_query *make_query(const char *last_update) > @@ -60,8 +61,24 @@ static void update_index(struct index_state *istate, > continue; > > pos =

[PATCH 19/19] hack: watchman/untracked cache mashup

2016-03-09 Thread David Turner
DO NOT APPLY THIS This is a hack to add untracked cache info to the watchman WAMA extension. The idea is that we don't have to stat directories if watchman hasn't told us of any changes in those dirs. If this is the right idea, I can go back and add it to the relevant patch(es). But I want to