Re: [PATCH 2/2] Git/Packet.pm: use 'if' instead of 'unless'

Jonathan Nieder writes: > [...] >> --- a/perl/Git/Packet.pm >> +++ b/perl/Git/Packet.pm >> @@ -68,16 +68,16 @@ sub packet_bin_read { >> >> sub remove_final_lf_or_die { >> my $buf = shift; >> -unless ( $buf =~ s/\n$// ) { > > For readability, I find this whitespace

Re: [PATCH 2/2] Git/Packet.pm: use 'if' instead of 'unless'

Hi, Christian Couder wrote: > The code is more understandable with 'if' instead of 'unless'. > > Signed-off-by: Christian Couder > --- > perl/Git/Packet.pm | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) I'm agnostic about that. In some ways

[PATCH 2/2] Git/Packet.pm: use 'if' instead of 'unless'

The code is more understandable with 'if' instead of 'unless'. Signed-off-by: Christian Couder --- perl/Git/Packet.pm | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/perl/Git/Packet.pm b/perl/Git/Packet.pm index