Re: [PATCH 2/2] bisect: rewrite `check_term_format` shell function in C

2016-05-04 Thread Junio C Hamano
Johannes Schindelin writes: > Maybe something like instead? > > static int one_of(const char *term, ...) > { > int res = 0; > va_list matches; > const char *match; > > va_start(matches, term); >

Re: [PATCH 2/2] bisect: rewrite `check_term_format` shell function in C

2016-05-04 Thread Pranit Bauva
On Wed, May 4, 2016 at 11:19 PM, Eric Sunshine wrote: > On Wed, May 4, 2016 at 7:58 AM, Pranit Bauva wrote: >> On Wed, May 4, 2016 at 1:58 PM, Eric Sunshine >> wrote: >>> On Wed, May 4, 2016 at 3:36 AM, Pranit Bauva

Re: [PATCH 2/2] bisect: rewrite `check_term_format` shell function in C

2016-05-04 Thread Eric Sunshine
On Wed, May 4, 2016 at 7:58 AM, Pranit Bauva wrote: > On Wed, May 4, 2016 at 1:58 PM, Eric Sunshine wrote: >> On Wed, May 4, 2016 at 3:36 AM, Pranit Bauva wrote: >>> On Wed, May 4, 2016 at 12:22 PM, Eric Sunshine

Re: [PATCH 2/2] bisect: rewrite `check_term_format` shell function in C

2016-05-04 Thread Christian Couder
On Wed, May 4, 2016 at 1:13 PM, Johannes Schindelin wrote: > Maybe something like instead? > > static int one_of(const char *term, ...) > { > int res = 0; > va_list matches; > const char *match; > >

Re: [PATCH 2/2] bisect: rewrite `check_term_format` shell function in C

2016-05-04 Thread Pranit Bauva
On Wed, May 4, 2016 at 4:43 PM, Johannes Schindelin wrote: > Hi Pranit, > > On Wed, 4 May 2016, Pranit Bauva wrote: > >> On Wed, May 4, 2016 at 12:22 PM, Eric Sunshine >> wrote: >> > On Wed, May 4, 2016 at 1:07 AM, Pranit Bauva

Re: [PATCH 2/2] bisect: rewrite `check_term_format` shell function in C

2016-05-04 Thread Pranit Bauva
On Wed, May 4, 2016 at 1:58 PM, Eric Sunshine wrote: > On Wed, May 4, 2016 at 3:36 AM, Pranit Bauva wrote: >> On Wed, May 4, 2016 at 12:22 PM, Eric Sunshine >> wrote: >>> On Wed, May 4, 2016 at 1:07 AM, Pranit Bauva

Re: [PATCH 2/2] bisect: rewrite `check_term_format` shell function in C

2016-05-04 Thread Johannes Schindelin
Hi Pranit, On Wed, 4 May 2016, Pranit Bauva wrote: > On Wed, May 4, 2016 at 12:22 PM, Eric Sunshine > wrote: > > On Wed, May 4, 2016 at 1:07 AM, Pranit Bauva wrote: > > > >> +static int one_of(const char *term, ...) > >> +{ > >> + va_list

Re: [PATCH 2/2] bisect: rewrite `check_term_format` shell function in C

2016-05-04 Thread Christian Couder
On Wed, May 4, 2016 at 10:28 AM, Eric Sunshine wrote: > On Wed, May 4, 2016 at 3:36 AM, Pranit Bauva wrote: >> On Wed, May 4, 2016 at 12:22 PM, Eric Sunshine >> wrote: >>> On Wed, May 4, 2016 at 1:07 AM, Pranit Bauva

Re: [PATCH 2/2] bisect: rewrite `check_term_format` shell function in C

2016-05-04 Thread Eric Sunshine
On Wed, May 4, 2016 at 3:36 AM, Pranit Bauva wrote: > On Wed, May 4, 2016 at 12:22 PM, Eric Sunshine > wrote: >> On Wed, May 4, 2016 at 1:07 AM, Pranit Bauva wrote: >> Okay, I'll bite: Why is this a good idea? What does

Re: [PATCH 2/2] bisect: rewrite `check_term_format` shell function in C

2016-05-04 Thread Pranit Bauva
On Wed, May 4, 2016 at 1:06 PM, Pranit Bauva wrote: > > [1]: http://article.gmane.org/gmane.comp.version-control.git/293489 > > [2]: http://article.gmane.org/gmane.comp.version-control.git/293489 > > [3]: http://article.gmane.org/gmane.comp.version-control.git/293489

Re: [PATCH 2/2] bisect: rewrite `check_term_format` shell function in C

2016-05-04 Thread Pranit Bauva
On Wed, May 4, 2016 at 12:22 PM, Eric Sunshine wrote: > On Wed, May 4, 2016 at 1:07 AM, Pranit Bauva wrote: >> This reimplements the `check_term_format` shell function in C and adds > > s/This reimplements/Reimplement/ > s/adds/add/ > >> a

Re: [PATCH 2/2] bisect: rewrite `check_term_format` shell function in C

2016-05-04 Thread Eric Sunshine
On Wed, May 4, 2016 at 1:07 AM, Pranit Bauva wrote: > This reimplements the `check_term_format` shell function in C and adds s/This reimplements/Reimplement/ s/adds/add/ > a `--check-term-format` subcommand to `git bisect--helper` to call it > from git-bisect.sh s/$/./

[PATCH 2/2] bisect: rewrite `check_term_format` shell function in C

2016-05-03 Thread Pranit Bauva
This reimplements the `check_term_format` shell function in C and adds a `--check-term-format` subcommand to `git bisect--helper` to call it from git-bisect.sh Helped-by: Johannes Schindelein Mentored-by: Lars Schneider Mentored-by: