Re: [PATCH 2/2] describe: Exclude --all --match=PATTERN

2013-03-03 Thread Greg Price
On Wed, Feb 27, 2013 at 12:20:07PM -0800, Junio C Hamano wrote: Without --all the command considers only the annotated tags to base the descripion on, and with --all, a ref that is not annotated tags can be used as a base, but with a lower priority (if an annotated tag can describe a given

Re: [PATCH 2/2] describe: Exclude --all --match=PATTERN

2013-03-03 Thread Junio C Hamano
Greg Price pr...@mit.edu writes: On Wed, Feb 27, 2013 at 12:20:07PM -0800, Junio C Hamano wrote: Without --all the command considers only the annotated tags to base the descripion on, and with --all, a ref that is not annotated tags can be used as a base, but with a lower priority (if an

Re: [PATCH 2/2] describe: Exclude --all --match=PATTERN

2013-03-03 Thread Greg Price
On Sun, Mar 03, 2013 at 01:15:21PM -0800, Junio C Hamano wrote: Greg Price pr...@mit.edu writes: It seems to me that --all says two things: (a) allow unannotated (rather than only annotated) (b) allow refs of any name (rather than only tags) With --match, particularly because the

Re: [PATCH 2/2] describe: Exclude --all --match=PATTERN

2013-02-28 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: I am not sure if this is (1) behaviour is sometimes useful in narrow cases but is not explained well, (2) behaviour does not make sense in any situation, or (3) the combination can make sense if corrected, but the current behaviour is buggy. If it is

Re: [PATCH 2/2] describe: Exclude --all --match=PATTERN

2013-02-27 Thread Junio C Hamano
Greg Price pr...@mit.edu writes: Currently when --all is passed, the effect of --match is only to demote non-matching tags to be treated like non-tags. This is puzzling behavior and not consistent with the documentation, especially with the suggested usage of avoiding information leaks. The

[PATCH 2/2] describe: Exclude --all --match=PATTERN

2013-02-24 Thread Greg Price
Currently when --all is passed, the effect of --match is only to demote non-matching tags to be treated like non-tags. This is puzzling behavior and not consistent with the documentation, especially with the suggested usage of avoiding information leaks. The combination of --all and --match is an