Re: [PATCH 2/2] fsmonitor: Store fsmonitor bitmap before splitting index

On Mon, 13 Nov 2017, Ben Peart wrote: > Why do you redirect stdout to stderr and then and perform an "echo" > afterwards? I don't understand what benefit that provides. I removed this > logic and the test still passes so am confused as to what its purpose is. Ah -- the "echo" was purely to

Re: [PATCH 2/2] fsmonitor: Store fsmonitor bitmap before splitting index

On 11/9/2017 2:58 PM, Alex Vandiver wrote: ba1b9caca6 resolved the problem of the fsmonitor data being applied to the non-base index when reading; however, a similar problem exists when writing the index. Specifically, writing of the fsmonitor extension happens only after the work to split

Re: [PATCH 2/2] fsmonitor: Store fsmonitor bitmap before splitting index

Alex Vandiver writes: > ba1b9caca6 resolved the problem of the fsmonitor data being applied to (from SubmittingPatches) If you want to reference a previous commit in the history of a stable branch, use the format "abbreviated sha1 (subject, date)", with the subject enclosed

[PATCH 2/2] fsmonitor: Store fsmonitor bitmap before splitting index

ba1b9caca6 resolved the problem of the fsmonitor data being applied to the non-base index when reading; however, a similar problem exists when writing the index. Specifically, writing of the fsmonitor extension happens only after the work to split the index has been applied -- as such, the