Re: [PATCH 2/2] git-p4.py: support Python 2.4

2013-01-26 Thread Brandon Casey
On Sat, Jan 26, 2013 at 4:48 AM, Pete Wyckoff wrote: > draf...@gmail.com wrote on Fri, 25 Jan 2013 12:44 -0800: >> + sys.stdout.write(s); > One stray semicolon. Whoops. Thanks. > In terms of maintenance, I'll not run tests with 2.4 or 2.5 > myself, but maybe you would be willing to check

Re: [PATCH 2/2] git-p4.py: support Python 2.4

2013-01-26 Thread Pete Wyckoff
draf...@gmail.com wrote on Fri, 25 Jan 2013 12:44 -0800: > Python 2.4 lacks the following features: > >subprocess.check_call >struct.pack_into > > Take a cue from 460d1026 and provide an implementation of the > CalledProcessError exception. Then replace the calls to > subproccess.check_c

[PATCH 2/2] git-p4.py: support Python 2.4

2013-01-25 Thread Brandon Casey
Python 2.4 lacks the following features: subprocess.check_call struct.pack_into Take a cue from 460d1026 and provide an implementation of the CalledProcessError exception. Then replace the calls to subproccess.check_call with calls to subprocess.call that check the return status and raise