On Sat, Mar 16, 2013 at 03:06:22PM +0100, Michael Haggerty wrote:
refname = parse_ref_line(refline, sha1);
if (refname) {
- last = create_ref_entry(refname, sha1, flag, 1);
+ /*
+* Older git did not write
Older versions of pack-refs did not write peel lines for
refs outside of refs/tags. This meant that on reading the
pack-refs file, we might set the REF_KNOWS_PEELED flag for
such a ref, even though we do not know anything about its
peeled value.
The previous commit updated the writer to always
ACK, with one ignorable comment.
Michael
On 03/16/2013 10:01 AM, Jeff King wrote:
Older versions of pack-refs did not write peel lines for
refs outside of refs/tags. This meant that on reading the
pack-refs file, we might set the REF_KNOWS_PEELED flag for
such a ref, even though we do not
Jeff King p...@peff.net writes:
The simplest fix would be to always unset the
REF_KNOWS_PEELED flag for refs outside of refs/tags that do
not have a peel line (if it has a peel line, we know it is
valid, but we cannot assume a missing peel line means
anything). But that loses an important
On Sat, Mar 16, 2013 at 10:50:17PM -0700, Junio C Hamano wrote:
I however wonder if the above implies it may make sense to add this
on top? Perhaps it is not worth it, because it makes a difference
only to a repository with annotated tags outside refs/tags hierarchy
and still has the
5 matches
Mail list logo
