Re: [PATCH 2/2] sha1_file: fix iterating loose alternate objects

2015-02-09 Thread Kyle J. McKay
On Feb 8, 2015, at 17:15, Jeff King wrote: [...] Signed-off-by: Jonathon Mah m...@jonathonmah.com Helped-by: Kyle J. McKay mack...@gmail.com Signed-off-by: Jeff King p...@peff.net --- I think the S-O-B should still stand, as the code is now a mix of our work, and the tests are still Jonathon's.

[PATCH 2/2] sha1_file: fix iterating loose alternate objects

2015-02-08 Thread Jeff King
From: Jonathon Mah m...@jonathonmah.com The string in 'base' contains a path suffix to a specific object; when its value is used, the suffix must either be filled (as in stat_sha1_file, open_sha1_file, check_and_freshen_nonlocal) or cleared (as in prepare_packed_git) to avoid junk at the end.

Re: [PATCH 2/2] sha1_file: fix iterating loose alternate objects

2015-02-02 Thread Jonathon Mah
On 2015-02-02, at 09:53, Jeff King p...@peff.net wrote: I think this is probably the best fix, and is the pattern we use elsewhere when touching alt-base. We _could_ further change this to have for_each_loose_file_in_objdir actually use alt-base as its scratch buffer, writing the object

Re: [PATCH 2/2] sha1_file: fix iterating loose alternate objects

2015-02-02 Thread Jeff King
On Sun, Feb 01, 2015 at 01:55:33PM -0800, Jonathon Mah wrote: The string in 'base' contains a path suffix to a specific object; when its value is used, the suffix must either be filled (as in stat_sha1_file, open_sha1_file, check_and_freshen_nonlocal) or cleared (as in prepare_packed_git) to

[PATCH 2/2] sha1_file: fix iterating loose alternate objects

2015-02-01 Thread Jonathon Mah
The string in 'base' contains a path suffix to a specific object; when its value is used, the suffix must either be filled (as in stat_sha1_file, open_sha1_file, check_and_freshen_nonlocal) or cleared (as in prepare_packed_git) to avoid junk at the end. loose_from_alt_odb (introduced in