[PATCH 2/2] strbuf: add strbuf_tolower function

This makes config's lowercase() function public. Note that we could continue to offer a pure-string lowercase, but there would be no callers (in most pure-string cases, we actually duplicate and lowercase the duplicate). Signed-off-by: Jeff King p...@peff.net ---

Re: [PATCH 2/2] strbuf: add strbuf_tolower function

[re-adding list cc] On Thu, May 22, 2014 at 03:16:45PM +0200, Christian Couder wrote: +void strbuf_tolower(struct strbuf *sb) +{ + char *p; + for (p = sb-buf; *p; p++) + *p = tolower(*p); +} Last time I tried a change like the above, I was told that

Re: [PATCH 2/2] strbuf: add strbuf_tolower function

On May 22, 2014, at 06:42, Jeff King wrote: [re-adding list cc] On Thu, May 22, 2014 at 03:16:45PM +0200, Christian Couder wrote: +void strbuf_tolower(struct strbuf *sb) +{ + char *p; + for (p = sb-buf; *p; p++) + *p = tolower(*p); +} Last time I tried a change