Re: [PATCH 2/2] submodule.c: correctly handle nested submodules in is_submodule_modified

2017-03-30 Thread Junio C Hamano
Jonathan Nieder writes: > Stefan Beller wrote: > >> This bug fix also affects the default output (non-short, non-porcelain) >> of git-status, which is not tested here. > > Do you have an example? (In just the commit message would be fine, in > tests would be even better.) >

Re: [PATCH 2/2] submodule.c: correctly handle nested submodules in is_submodule_modified

2017-03-29 Thread Jonathan Nieder
Stefan Beller wrote: > This bug fix also affects the default output (non-short, non-porcelain) > of git-status, which is not tested here. Do you have an example? (In just the commit message would be fine, in tests would be even better.) > Signed-off-by: Stefan Beller > ---

[PATCH 2/2] submodule.c: correctly handle nested submodules in is_submodule_modified

2017-03-29 Thread Stefan Beller
Suppose I have a superproject 'super', with two submodules 'super/sub' and 'super/sub1'. 'super/sub' itself contains a submodule 'super/sub/subsub'. Now suppose I run, from within 'super': echo hi >sub/subsub/stray-file echo hi >sub1/stray-file Currently we get would see the following

Re: [PATCH 2/2] submodule.c: correctly handle nested submodules in is_submodule_modified

2017-03-29 Thread Stefan Beller
> sanity check: What does this do for a "2" line indicating a sub-submodule > that has been renamed that contains an untracked file? Do we need to > rely on some other indication to show this as a change? Oh. :( In case of 'u' and '2' we need to set DIRTY_SUBMODULE_MODIFIED additionally. will

Re: [PATCH 2/2] submodule.c: correctly handle nested submodules in is_submodule_modified

2017-03-28 Thread Jonathan Nieder
Stefan Beller wrote: > Suppose I have a superproject 'super', with two submodules 'super/sub' > and 'super/sub1'. 'super/sub' itself contains a submodule > 'super/sub/subsub'. Now suppose I run, from within 'super': > > echo hi >sub/subsub/stray-file > echo hi >sub1/stray-file > >

[PATCH 2/2] submodule.c: correctly handle nested submodules in is_submodule_modified

2017-03-28 Thread Stefan Beller
Suppose I have a superproject 'super', with two submodules 'super/sub' and 'super/sub1'. 'super/sub' itself contains a submodule 'super/sub/subsub'. Now suppose I run, from within 'super': echo hi >sub/subsub/stray-file echo hi >sub1/stray-file Currently we get would see the following