Re: [PATCH 2/2] test-lint: detect 'export FOO=bar'

2013-07-09 Thread Thomas Rast
Torsten Bögershausen tbo...@web.de writes: +/^\s*export\s+[^=]*=/ and err 'export FOO=bar is not portable (please use FOO=bar export FOO)'; I have a slightly tighter reg exp in my tree, but credits should go to Thomas: /^\s*export\s+\S+=\S+/ Hmm, is that correct? I would expect

Re: [PATCH 2/2] test-lint: detect 'export FOO=bar'

2013-07-09 Thread Torsten Bögershausen
On 09.07.13 11:28, Thomas Rast wrote: Torsten Bögershausen tbo...@web.de writes: + /^\s*export\s+[^=]*=/ and err 'export FOO=bar is not portable (please use FOO=bar export FOO)'; I have a slightly tighter reg exp in my tree, but credits should go to Thomas: /^\s*export\s+\S+=\S+/

[PATCH 2/2] test-lint: detect 'export FOO=bar'

2013-07-08 Thread Thomas Rast
Some shells do not understand the one-line construct, and instead need FOO=bar export FOO Detect this in the test-lint target. Signed-off-by: Thomas Rast tr...@inf.ethz.ch --- I wrote: Torsten Bögershausen tbo...@web.de writes: [...] - export HARNESS_ACTIVE=t +

Re: [PATCH 2/2] test-lint: detect 'export FOO=bar'

2013-07-08 Thread Torsten Bögershausen
On 2013-07-08 17.20, Thomas Rast wrote: Some shells do not understand the one-line construct, and instead need FOO=bar export FOO Detect this in the test-lint target. Signed-off-by: Thomas Rast tr...@inf.ethz.ch --- I wrote: Torsten Bögershausen tbo...@web.de writes: [...]