Re: [PATCH 2/3] Move copy_note_for_rewrite + friends from builtin/notes.c to notes-utils.c

2013-06-13 Thread Andreas Krey
On Wed, 12 Jun 2013 13:28:05 +, Felipe Contreras wrote: ... And you are doing that with the express purpose of annoying. Where did 'assume good faith' go to today? Andreas -- Totally trivial. Famous last words. From: Linus Torvalds torvalds@*.org Date: Fri, 22 Jan 2010 07:29:21 -0800 --

Re: [PATCH 2/3] Move copy_note_for_rewrite + friends from builtin/notes.c to notes-utils.c

2013-06-13 Thread Felipe Contreras
On Thu, Jun 13, 2013 at 1:45 AM, Andreas Krey a.k...@gmx.de wrote: On Wed, 12 Jun 2013 13:28:05 +, Felipe Contreras wrote: ... And you are doing that with the express purpose of annoying. Where did 'assume good faith' go to today? Did you read the last part? This does not mean that one

Re: [PATCH 2/3] Move copy_note_for_rewrite + friends from builtin/notes.c to notes-utils.c

2013-06-12 Thread Johan Herland
On Wed, Jun 12, 2013 at 2:32 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Tue, Jun 11, 2013 at 7:13 PM, Johan Herland jo...@herland.net wrote: This is a pure code movement of the machinery for copying notes to rewritten objects. This code was located in builtin/notes.c for

Re: [PATCH 2/3] Move copy_note_for_rewrite + friends from builtin/notes.c to notes-utils.c

2013-06-12 Thread Felipe Contreras
On Wed, Jun 12, 2013 at 2:10 AM, Johan Herland jo...@herland.net wrote: On Wed, Jun 12, 2013 at 2:32 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Tue, Jun 11, 2013 at 7:13 PM, Johan Herland jo...@herland.net wrote: This is a pure code movement of the machinery for copying notes to

Re: [PATCH 2/3] Move copy_note_for_rewrite + friends from builtin/notes.c to notes-utils.c

2013-06-12 Thread Johan Herland
On Wed, Jun 12, 2013 at 8:28 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Wed, Jun 12, 2013 at 2:10 AM, Johan Herland jo...@herland.net wrote: On Wed, Jun 12, 2013 at 2:32 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Tue, Jun 11, 2013 at 7:13 PM, Johan Herland

Re: [PATCH 2/3] Move copy_note_for_rewrite + friends from builtin/notes.c to notes-utils.c

2013-06-12 Thread Felipe Contreras
Johan Herland wrote: On Wed, Jun 12, 2013 at 8:28 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Wed, Jun 12, 2013 at 2:10 AM, Johan Herland jo...@herland.net wrote: On Wed, Jun 12, 2013 at 2:32 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Tue, Jun 11, 2013 at

Re: [PATCH 2/3] Move copy_note_for_rewrite + friends from builtin/notes.c to notes-utils.c

2013-06-12 Thread Junio C Hamano
Johan Herland jo...@herland.net writes: This is a pure code movement of the machinery for copying notes to rewritten objects. This code was located in builtin/notes.c for historical reasons. In order to make it available to builtin/commit.c it was declared in builtin.h. This was more of an

[PATCH 2/3] Move copy_note_for_rewrite + friends from builtin/notes.c to notes-utils.c

2013-06-11 Thread Johan Herland
This is a pure code movement of the machinery for copying notes to rewritten objects. This code was located in builtin/notes.c for historical reasons. In order to make it available to builtin/commit.c it was declared in builtin.h. This was more of an accident of history than a concious design, and

Re: [PATCH 2/3] Move copy_note_for_rewrite + friends from builtin/notes.c to notes-utils.c

2013-06-11 Thread Felipe Contreras
On Tue, Jun 11, 2013 at 7:13 PM, Johan Herland jo...@herland.net wrote: This is a pure code movement of the machinery for copying notes to rewritten objects. This code was located in builtin/notes.c for historical reasons. In order to make it available to builtin/commit.c it was declared in