[PATCH 2/3] commit: check committer identity more strictly

2012-07-23 Thread Jeff King
The identity of the committer will ultimately be pulled from the ident code by commit_tree(). However, we make an attempt to check the author and committer identity early, before the user has done any manual work like inputting a commit message. That lets us abort without them having to worry

Re: [PATCH 2/3] commit: check committer identity more strictly

2012-07-23 Thread Junio C Hamano
Jeff King p...@peff.net writes: Incidentally, this bug was masked prior to 060d4bb, as the initial loose call would taint the later strict call. So the commit would succeed (albeit with a bogus committer line in the commit object), and nobody noticed that our early check did not match the

Re: [PATCH 2/3] commit: check committer identity more strictly

2012-07-23 Thread Jeff King
On Mon, Jul 23, 2012 at 01:51:25PM -0700, Junio C Hamano wrote: diff --git a/builtin/commit.c b/builtin/commit.c index 95eeab1..20cef95 100644 --- a/builtin/commit.c +++ b/builtin/commit.c @@ -725,7 +725,7 @@ static int prepare_to_commit(const char *index_file, const char *prefix,