On Fri, Sep 09, 2016 at 02:58:25PM +0200, Johannes Schindelin wrote:
> > Yes, I agree that this is the opposite direction of libification. And I
> > agree that the current message is not very helpful.
> >
> > But I am not sure that returning the error up the stack will actually
> > help somebody
Hi Peff,
On Fri, 9 Sep 2016, Jeff King wrote:
> On Fri, Sep 09, 2016 at 12:28:38PM +0200, Johannes Schindelin wrote:
>
> > I like the simplification, but I *hate* the fact that the calling code has
> > *no way* to inform the user about the proper next steps.
> >
> > You are touching code that
On Fri, Sep 09, 2016 at 12:28:38PM +0200, Johannes Schindelin wrote:
> I like the simplification, but I *hate* the fact that the calling code has
> *no way* to inform the user about the proper next steps.
>
> You are touching code that is really quite at the bottom of a lot of call
> chains. For
Hi Peff,
On Wed, 7 Sep 2016, Jeff King wrote:
> All of our errors come from diff_get_patch_id(), which has
> exactly three error conditions. The first is an internal
> assertion, which should be a die("BUG") in the first place.
>
> The other two are caused by an inability to two diff blobs,
>
On Thu, Sep 08, 2016 at 01:51:05AM +0100, Ramsay Jones wrote:
>
>
> On 07/09/16 23:04, Jeff King wrote:
> > All of our errors come from diff_get_patch_id(), which has
> > exactly three error conditions. The first is an internal
> > assertion, which should be a die("BUG") in the first place.
> >
On 07/09/16 23:04, Jeff King wrote:
> All of our errors come from diff_get_patch_id(), which has
> exactly three error conditions. The first is an internal
> assertion, which should be a die("BUG") in the first place.
>
> The other two are caused by an inability to two diff blobs,
All of our errors come from diff_get_patch_id(), which has
exactly three error conditions. The first is an internal
assertion, which should be a die("BUG") in the first place.
The other two are caused by an inability to two diff blobs,
which is an indication of a serious problem (probably
7 matches
Mail list logo