Re: [PATCH 2/3] gc: exit with status 128 on failure

2018-09-18 Thread Jeff King
On Mon, Sep 17, 2018 at 11:40:12AM -0700, Jonathan Nieder wrote: > > There's discussion elsewhere[1] of applying just up to patch 2. > > > > Do we still want to convert these cases to die() as their end-state? > > IMHO yes, we do. die() is the function that you can use to exit with > a fatal

Re: [PATCH 2/3] gc: exit with status 128 on failure

2018-09-17 Thread Jonathan Nieder
Hi, Jeff King wrote: > On Tue, Jul 17, 2018 at 03:59:47PM -0400, Jeff King wrote: >> On Mon, Jul 16, 2018 at 11:54:16PM -0700, Jonathan Nieder wrote: >>> A value of -1 returned from cmd_gc gets propagated to exit(), >>> resulting in an exit status of 255. Use die instead for a clearer >>> error

Re: [PATCH 2/3] gc: exit with status 128 on failure

2018-09-17 Thread Jeff King
On Tue, Jul 17, 2018 at 03:59:47PM -0400, Jeff King wrote: > On Mon, Jul 16, 2018 at 11:54:16PM -0700, Jonathan Nieder wrote: > > > A value of -1 returned from cmd_gc gets propagated to exit(), > > resulting in an exit status of 255. Use die instead for a clearer > > error message and a

Re: [PATCH 2/3] gc: exit with status 128 on failure

2018-07-17 Thread Jeff King
On Mon, Jul 16, 2018 at 11:54:16PM -0700, Jonathan Nieder wrote: > A value of -1 returned from cmd_gc gets propagated to exit(), > resulting in an exit status of 255. Use die instead for a clearer > error message and a controlled exit. This feels a little funny because we know we're going to

Re: [PATCH 2/3] gc: exit with status 128 on failure

2018-07-17 Thread Junio C Hamano
Jonathan Nieder writes: > A value of -1 returned from cmd_gc gets propagated to exit(), > resulting in an exit status of 255. Use die instead for a clearer > error message and a controlled exit. > > Signed-off-by: Jonathan Nieder > --- > As in >

[PATCH 2/3] gc: exit with status 128 on failure

2018-07-17 Thread Jonathan Nieder
A value of -1 returned from cmd_gc gets propagated to exit(), resulting in an exit status of 255. Use die instead for a clearer error message and a controlled exit. Signed-off-by: Jonathan Nieder --- As in https://public-inbox.org/git/20180716225639.gk11...@aiede.svl.corp.google.com/. The only