Re: [PATCH 2/3] git-column.1: clarify initial description, provide examples

2018-09-21 Thread frederik
Thank you Junio, maybe I will have another chance to get practice sending a v2 patch. On Fri, Sep 21, 2018 at 09:32:00AM -0700, Junio C Hamano wrote: > frede...@ofb.net writes: > > > On Thu, Sep 20, 2018 at 06:23:03PM +0200, Duy Nguyen wrote: > >> On Wed, Sep 19, 2018 at 03:59:58PM -0700, Junio

Re: [PATCH 2/3] git-column.1: clarify initial description, provide examples

2018-09-21 Thread Junio C Hamano
frede...@ofb.net writes: > On Thu, Sep 20, 2018 at 06:23:03PM +0200, Duy Nguyen wrote: >> On Wed, Sep 19, 2018 at 03:59:58PM -0700, Junio C Hamano wrote: >> > > @@ -23,7 +26,7 @@ OPTIONS >> > > >> > > --mode=:: >> > > Specify layout mode. See configuration variable column.ui for >> >

Re: [PATCH 2/3] git-column.1: clarify initial description, provide examples

2018-09-20 Thread Eric Sunshine
On Thu, Sep 20, 2018 at 1:47 PM wrote: > On Thu, Sep 20, 2018 at 06:23:03PM +0200, Duy Nguyen wrote: > > On Wed, Sep 19, 2018 at 03:59:58PM -0700, Junio C Hamano wrote: > > > > @@ -23,7 +26,7 @@ OPTIONS > > > > > > > > --mode=:: > > > > Specify layout mode. See configuration variable column.ui

Re: [PATCH 2/3] git-column.1: clarify initial description, provide examples

2018-09-20 Thread frederik
On Thu, Sep 20, 2018 at 06:23:03PM +0200, Duy Nguyen wrote: > On Wed, Sep 19, 2018 at 03:59:58PM -0700, Junio C Hamano wrote: > > > @@ -23,7 +26,7 @@ OPTIONS > > > > > > --mode=:: > > > Specify layout mode. See configuration variable column.ui for option > > > - syntax. > > > + syntax (in

Re: [PATCH 2/3] git-column.1: clarify initial description, provide examples

2018-09-20 Thread Duy Nguyen
On Wed, Sep 19, 2018 at 03:59:58PM -0700, Junio C Hamano wrote: > > @@ -23,7 +26,7 @@ OPTIONS > > > > --mode=:: > > Specify layout mode. See configuration variable column.ui for option > > - syntax. > > + syntax (in git-config(1)). I think we usually link to other commands with

Re: [PATCH 2/3] git-column.1: clarify initial description, provide examples

2018-09-19 Thread Junio C Hamano
Frederick Eaton writes: > When I read this man page I couldn't figure out what kind of input it > was referring to, or how input was being put into columns, or where I > should look for the syntax of the --mode option. > > Signed-off-by: Frederick Eaton > --- > Documentation/git-column.txt |

[PATCH 2/3] git-column.1: clarify initial description, provide examples

2018-09-19 Thread Frederick Eaton
When I read this man page I couldn't figure out what kind of input it was referring to, or how input was being put into columns, or where I should look for the syntax of the --mode option. Signed-off-by: Frederick Eaton --- Documentation/git-column.txt | 35 +--