Re: [PATCH 2/3] gpg-interface: provide access to the payload

2014-06-13 Thread Jeff King
On Fri, Jun 06, 2014 at 04:15:27PM +0200, Michael J Gruber wrote: diff --git a/builtin/merge.c b/builtin/merge.c [...] + free(signature_check.payload); free(signature_check.gpg_output); free(signature_check.gpg_status);

Re: [PATCH 2/3] gpg-interface: provide access to the payload

2014-06-13 Thread Michael J Gruber
Jeff King venit, vidit, dixit 13.06.2014 09:55: On Fri, Jun 06, 2014 at 04:15:27PM +0200, Michael J Gruber wrote: diff --git a/builtin/merge.c b/builtin/merge.c [...] +free(signature_check.payload); free(signature_check.gpg_output);

Re: [PATCH 2/3] gpg-interface: provide access to the payload

2014-06-13 Thread Jeff King
On Fri, Jun 13, 2014 at 11:44:28AM +0200, Michael J Gruber wrote: Perhaps this is a sign that we need a signature_check_clear() helper? ... or simply switch to language which has (or can overload) free for an object :) I hear somebody has reimplemented git in pure javascript. ;P Do we

[PATCH 2/3] gpg-interface: provide access to the payload

2014-06-06 Thread Michael J Gruber
In contrast to tag signatures, commit signatures are put into the header, that is between the other header parts and commit messages. Provide access to the commit content sans the signature, which is the payload that is actually signed. Commit signature verification does the parsing anyways, and