Re: [PATCH 2/3] submodule tests: replace cloning from . by "$(pwd)"

2016-10-24 Thread Johannes Sixt
Am 24.10.2016 um 21:10 schrieb Stefan Beller: The ease of use in our own testing suite is the feature I was talking about. Ok, thanks for the clarification. Next steps would then be, IMO, to fix the tests to match the future world order and mark tests that fail due to the bug with

Re: [PATCH 2/3] submodule tests: replace cloning from . by "$(pwd)"

2016-10-24 Thread Stefan Beller
On Sun, Oct 23, 2016 at 3:14 AM, Johannes Sixt wrote: > Am 22.10.2016 um 22:46 schrieb Stefan Beller: >> >> I have looked into it again, and by now I think the bug is a feature, >> actually. >> >> Consider this: >> >> git clone . super >> git -C super submodule add

Re: [PATCH 2/3] submodule tests: replace cloning from . by "$(pwd)"

2016-10-24 Thread Junio C Hamano
Johannes Sixt writes: > Am 22.10.2016 um 22:46 schrieb Stefan Beller: >> I have looked into it again, and by now I think the bug is a feature, >> actually. >> >> Consider this: >> >> git clone . super >> git -C super submodule add ../submodule >> # we thought the

Re: [PATCH 2/3] submodule tests: replace cloning from . by "$(pwd)"

2016-10-23 Thread Johannes Sixt
Am 22.10.2016 um 22:46 schrieb Stefan Beller: I have looked into it again, and by now I think the bug is a feature, actually. Consider this: git clone . super git -C super submodule add ../submodule # we thought the previous line is buggy git clone super super-clone At this

Re: [PATCH 2/3] submodule tests: replace cloning from . by "$(pwd)"

2016-10-22 Thread Stefan Beller
On Sat, Oct 22, 2016 at 12:33 AM, Junio C Hamano wrote: > Johannes Sixt writes: > >>> The logic to construct the relative urls is not smart enough to >>> detect that the ending /. is referring to the directory itself >>> but rather treats it like any other

Re: [PATCH 2/3] submodule tests: replace cloning from . by "$(pwd)"

2016-10-22 Thread Junio C Hamano
Johannes Sixt writes: >> The logic to construct the relative urls is not smart enough to >> detect that the ending /. is referring to the directory itself >> but rather treats it like any other relative path, i.e. >> >> path/to/dir/. + ../relative/path/to/submodule >> >> would

Re: [PATCH 2/3] submodule tests: replace cloning from . by "$(pwd)"

2016-10-22 Thread Johannes Sixt
Am 22.10.2016 um 01:59 schrieb Stefan Beller: When adding a submodule via "git submodule add ", the relative url applies to the superprojects remote. When the superproject was cloned via "git clone . super", the remote url is ending with '/.'. The logic to construct the relative urls is not

[PATCH 2/3] submodule tests: replace cloning from . by "$(pwd)"

2016-10-21 Thread Stefan Beller
When adding a submodule via "git submodule add ", the relative url applies to the superprojects remote. When the superproject was cloned via "git clone . super", the remote url is ending with '/.'. The logic to construct the relative urls is not smart enough to detect that the ending /. is