Re: [PATCH 2/4] builtin/interpret-trailers: suppress blank line

2016-04-10 Thread Michael S. Tsirkin
On Thu, Apr 07, 2016 at 10:34:51AM -0700, Junio C Hamano wrote: > "Michael S. Tsirkin" writes: > > > No - but then I will need to re-run mailinfo to parse the result, > > will I not? > > By the way, I suspect (if Christian did his implementation right > when he did

Re: [PATCH 2/4] builtin/interpret-trailers: suppress blank line

2016-04-07 Thread Matthieu Moy
"Michael S. Tsirkin" writes: > it's sometimes useful to be able to pass output message of > git-mailinfo through git-interpret-trailers, > but that creates problems since that does not > include the subject and an empty line after that, > making interpret-trailers add an empty

Re: [PATCH 2/4] builtin/interpret-trailers: suppress blank line

2016-04-07 Thread Junio C Hamano
"Michael S. Tsirkin" writes: > No - but then I will need to re-run mailinfo to parse the result, > will I not? By the way, I suspect (if Christian did his implementation right when he did interpret-trailers) all these points may become moot. I haven't re-reviewed what is in

Re: [PATCH 2/4] builtin/interpret-trailers: suppress blank line

2016-04-07 Thread Michael S. Tsirkin
On Thu, Apr 07, 2016 at 10:00:37AM -0700, Junio C Hamano wrote: > "Michael S. Tsirkin" writes: > > > it's sometimes useful to be able to pass output message of > > git-mailinfo through git-interpret-trailers, > > but that creates problems since that does not > > include the

Re: [PATCH 2/4] builtin/interpret-trailers: suppress blank line

2016-04-07 Thread Junio C Hamano
Junio C Hamano writes: > "Michael S. Tsirkin" writes: > >> it's sometimes useful to be able to pass output message of >> git-mailinfo through git-interpret-trailers, >> but that creates problems since that does not >> include the subject and an empty line

Re: [PATCH 2/4] builtin/interpret-trailers: suppress blank line

2016-04-07 Thread Junio C Hamano
"Michael S. Tsirkin" writes: > it's sometimes useful to be able to pass output message of > git-mailinfo through git-interpret-trailers, > but that creates problems since that does not > include the subject and an empty line after that, > making interpret-trailers add an empty

[PATCH 2/4] builtin/interpret-trailers: suppress blank line

2016-04-07 Thread Michael S. Tsirkin
it's sometimes useful to be able to pass output message of git-mailinfo through git-interpret-trailers, but that creates problems since that does not include the subject and an empty line after that, making interpret-trailers add an empty line. Add a flag to bypass adding the blank line.