Re: [PATCH 2/5] difftool: Eliminate global variables

2012-07-22 Thread Sebastian Schuberth
On Mon, Jul 23, 2012 at 8:44 AM, David Aguilar wrote: >> Well, I'm not asking for a test. From my side, I'd be happy if you >> could just try it and confirm that it works, as I currently cannot >> easily apply your patch. > > Heheh.. I was hoping you could provide a test ;-) ;-) > I just tried

Re: [PATCH 2/5] difftool: Eliminate global variables

2012-07-22 Thread David Aguilar
On Sun, Jul 22, 2012 at 11:30 PM, Sebastian Schuberth wrote: > On Mon, Jul 23, 2012 at 8:21 AM, David Aguilar wrote: > >>> Funny, I just have prepared a patch along the same lines so that one can >>> call git-difftool -h and --tool-help also outside a repository, see below. >>> Does you patch off

Re: [PATCH 2/5] difftool: Eliminate global variables

2012-07-22 Thread Sebastian Schuberth
On Mon, Jul 23, 2012 at 8:21 AM, David Aguilar wrote: >> Funny, I just have prepared a patch along the same lines so that one can >> call git-difftool -h and --tool-help also outside a repository, see below. >> Does you patch offer the same? If so, I'll drop mine. > > It *should*. I did not consi

Re: [PATCH 2/5] difftool: Eliminate global variables

2012-07-22 Thread David Aguilar
On Sun, Jul 22, 2012 at 11:13 PM, Sebastian Schuberth wrote: > On 23.07.2012 05:42, David Aguilar wrote: > >> Organize the script so that it has a single main() function which >> calls out to dir_diff() and file_diff() functions. This eliminates >> "dir-diff"-specific variables that do not need to

Re: [PATCH 2/5] difftool: Eliminate global variables

2012-07-22 Thread Sebastian Schuberth
On 23.07.2012 05:42, David Aguilar wrote: Organize the script so that it has a single main() function which calls out to dir_diff() and file_diff() functions. This eliminates "dir-diff"-specific variables that do not need to be calculated when performing a regular file-diff. Funny, I just have

[PATCH 2/5] difftool: Eliminate global variables

2012-07-22 Thread David Aguilar
Organize the script so that it has a single main() function which calls out to dir_diff() and file_diff() functions. This eliminates "dir-diff"-specific variables that do not need to be calculated when performing a regular file-diff. Signed-off-by: David Aguilar --- Same as before, resending beca

[PATCH 2/5] difftool: Eliminate global variables

2012-07-22 Thread David Aguilar
Organize the script so that it has a single main() function which calls out to dir_diff() and file_diff() functions. This eliminates "dir-diff"-specific variables that do not need to be calculated when performing a regular file-diff. Signed-off-by: David Aguilar --- git-difftool.perl | 128 +