Re: [PATCH 28/36] attr: keep attr stack for each check

2016-10-26 Thread Stefan Beller
On Sun, Oct 23, 2016 at 8:10 AM, Ramsay Jones wrote: >> + >> +struct hashmap all_attr_stacks; >> +int all_attr_stacks_init; > > Mark symbols 'all_attr_stacks' and 'all_attr_stacks_init' with > the static keyword. (ie. these are file-local symbols). > > ATB, > Ramsay

Re: [PATCH 28/36] attr: keep attr stack for each check

2016-10-24 Thread Junio C Hamano
Stefan Beller writes: > I looked for a platform independent way to get a thread id as a natural > number, i.e. I want to get 1,2,3,... such that I could have just added > list/array of attr stacks to each check, which would be the > tuple you envision. > >

Re: [PATCH 28/36] attr: keep attr stack for each check

2016-10-24 Thread Stefan Beller
On Mon, Oct 24, 2016 at 12:07 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> Instead of having a global attr stack, attach the stack to each check. > > Two threads may be working on "git checkout", one "git_attr_check" > in convert.c may be used by

Re: [PATCH 28/36] attr: keep attr stack for each check

2016-10-24 Thread Junio C Hamano
Stefan Beller writes: > Instead of having a global attr stack, attach the stack to each check. Two threads may be working on "git checkout", one "git_attr_check" in convert.c may be used by them to learn the EOL conversion for each path, and these threads are working in

Re: [PATCH 28/36] attr: keep attr stack for each check

2016-10-23 Thread Ramsay Jones
On 23/10/16 00:32, Stefan Beller wrote: > Instead of having a global attr stack, attach the stack to each check. > This allows to use the attr in a multithreaded way. > > > > Signed-off-by: Stefan Beller > --- > attr.c| 101 >

[PATCH 28/36] attr: keep attr stack for each check

2016-10-22 Thread Stefan Beller
Instead of having a global attr stack, attach the stack to each check. This allows to use the attr in a multithreaded way. Signed-off-by: Stefan Beller --- attr.c| 101 +++--- attr.h| 4 ++- hashmap.h | 2