Rasmus Villemoes writes:
>> It may be surprising to existing users that
>> the command now suddenly adds more addresses the user did not think
>> would be added, but it would probably be easy enough for them to
>> work around.
>
> Yeah, I thought about that, but unfortunately the whole auto-cc
On 2018-10-16 07:57, Junio C Hamano wrote:
> Rasmus Villemoes writes:
>
>>> I wonder if it would make it easier to grok if we made the logic
>>> inside out, i.e.
>>>
>>> if ($sc eq $sender) {
>>> ...
>>> } else {
>>> if ($what =~ /^Signed-off-by$/i) {
>>>
Rasmus Villemoes writes:
>> I wonder if it would make it easier to grok if we made the logic
>> inside out, i.e.
>>
>> if ($sc eq $sender) {
>> ...
>> } else {
>> if ($what =~ /^Signed-off-by$/i) {
>> next if $suppress_cc{'sob'};
>>
On 2018-10-11 08:18, Junio C Hamano wrote:
> Rasmus Villemoes writes:
> we now ...
>
>> +next if $suppress_cc{'sob'} and $what =~
>> /^Signed-off-by$/i;
>
> ... must make sure what we have is _exactly_ "signed-off-by" when
> 'sob' is suppressed. Makes sense.
>
Rasmus Villemoes writes:
> @@ -1681,7 +1681,7 @@ sub process_file {
> # Now parse the message body
> while(<$fh>) {
> $message .= $_;
> - if (/^(Signed-off-by|Cc): (.*)/i) {
> + if (/^([a-z-]*-by|Cc): (.*)/i) {
So this picks up anything-by not
On Wed, Oct 10 2018, Rasmus Villemoes wrote:
> - next if $suppress_cc{'sob'} and $what =~
> /Signed-off-by/i;
> + next if $suppress_cc{'sob'} and $what =~
> /^Signed-off-by$/i;
> + next if
When rerolling a patch series, including various Reviewed-by etc. that
may have come in, it is quite convenient to have git-send-email
automatically cc those people.
So pick up any *-by lines, with a new suppression category 'misc-by',
but special-case Signed-off-by, since that already has its
7 matches
Mail list logo
