On Fri, May 17, 2013 at 12:14 PM, Matthieu Moy
wrote:
> Felipe Contreras writes:
>
>> On Fri, May 17, 2013 at 11:56 AM, Matthieu Moy
>> wrote:
>>> Felipe Contreras writes:
>>>
THERE IS NO STYLE BREAKAGE.
>>>
>>> Repeating something, and even making it all caps does not make it true.
>>
>>
Felipe Contreras writes:
> On Fri, May 17, 2013 at 11:56 AM, Matthieu Moy
> wrote:
>> Felipe Contreras writes:
>>
>>> THERE IS NO STYLE BREAKAGE.
>>
>> Repeating something, and even making it all caps does not make it true.
>
> Tell that to Junio. He is also repeating the same.
Junio explained
On Fri, May 17, 2013 at 11:56 AM, Matthieu Moy
wrote:
> Felipe Contreras writes:
>
>> THERE IS NO STYLE BREAKAGE.
>
> Repeating something, and even making it all caps does not make it true.
Tell that to Junio. He is also repeating the same.
I actually provided *evidence*. Did you miss it?
> Yo
Felipe Contreras writes:
> THERE IS NO STYLE BREAKAGE.
Repeating something, and even making it all caps does not make it true.
You are wasting your time and everybody else's in this thread and many
others. You seem to reject the very concept of code review. The Git
community likes very much cod
On Fri, May 17, 2013 at 11:22 AM, Junio C Hamano wrote:
> Felipe Contreras writes:
>
>> *You* are telling my that; it's *your* opinion and nothing else. It's
>
> I saw a review comment that points out that the continuation lines
> do not align, and you refused to say "ah, thanks for spotting" and
Felipe Contreras writes:
> *You* are telling my that; it's *your* opinion and nothing else. It's
I saw a review comment that points out that the continuation lines
do not align, and you refused to say "ah, thanks for spotting" and
reroll [*1*], so even I do not want to do so in general, I had to
On Fri, May 17, 2013 at 1:04 AM, Ramkumar Ramachandra
wrote:
> Felipe Contreras wrote:
>> This is what Linux's checkpatch throws:
>
> Perhaps it's time to include checkpatch.pl in our tree and update our
> CodingGuidelines?
checkpatch only works with a Linux tree, and it doesn't treat this
alignm
Felipe Contreras wrote:
> This is what Linux's checkpatch throws:
Perhaps it's time to include checkpatch.pl in our tree and update our
CodingGuidelines?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Thu, May 16, 2013 at 6:54 PM, Felipe Contreras
wrote:
> There are 535 instances where parenthesis are not aligned. Do you
> still think aligning open parenthesis is the "style of the project"?
>
> Please. You are rejecting this patch on a whim, and nothing more.
And FTR. I shouldn't need to w
On Thu, May 16, 2013 at 1:34 PM, Ramkumar Ramachandra
wrote:
> Junio C Hamano wrote:
>> (defun linux-style ()
>> "C mode with adjusted defaults for use with the Linux kernel."
>> (interactive)
>> (c-set-style "K&R")
>
> There's actually a "linux" style you can inherit from.
>
Junio C Hamano wrote:
> (defun linux-style ()
> "C mode with adjusted defaults for use with the Linux kernel."
> (interactive)
> (c-set-style "K&R")
There's actually a "linux" style you can inherit from.
May I suggest looking at Documentation/CodingStyle in linux.git for thi
Felipe Contreras writes:
> You find it sensible, I don't. And when people disagree, that's what
> the guideline is for.
If you really need it to be spelled out, I would say it would be
something like this:
(defun linux-style ()
"C mode with adjusted defaults for use with the Linux ke
On Thu, May 16, 2013 at 11:49 AM, Junio C Hamano wrote:
> Felipe Contreras writes:
>
>> On Thu, May 16, 2013 at 11:19 AM, Junio C Hamano wrote:
>>> Felipe Contreras writes:
>>>
I find it extremely annoying that an obviously correct patch is not
merged...
>>>
>>> A patch that receives
Felipe Contreras writes:
> On Thu, May 16, 2013 at 11:19 AM, Junio C Hamano wrote:
>> Felipe Contreras writes:
>>
>>> I find it extremely annoying that an obviously correct patch is not
>>> merged...
>>
>> A patch that receives "this breaks style" comments
>
> *Invalid* "this breaks style" comm
On Thu, May 16, 2013 at 11:19 AM, Junio C Hamano wrote:
> Felipe Contreras writes:
>
>> I find it extremely annoying that an obviously correct patch is not
>> merged...
>
> A patch that receives "this breaks style" comments
*Invalid* "this breaks style" comments, because it doesn't break any
sty
Felipe Contreras writes:
> I find it extremely annoying that an obviously correct patch is not
> merged...
A patch that receives "this breaks style" comments and its author
stubbornly refusing to fix what others pointed out, especially when
the patch itself _is_ about style, cannot be "an obviou
On Thu, May 9, 2013 at 6:12 PM, Felipe Contreras
wrote:
> On Thu, May 9, 2013 at 6:09 PM, Junio C Hamano wrote:
>> John Szakmeister writes:
>>
>>> On Wed, May 8, 2013 at 9:16 PM, Felipe Contreras
>>> wrote:
Signed-off-by: Felipe Contreras
---
builtin/fast-export.c | 24
On Thu, May 9, 2013 at 6:09 PM, Junio C Hamano wrote:
> John Szakmeister writes:
>
>> On Wed, May 8, 2013 at 9:16 PM, Felipe Contreras
>> wrote:
>>> Signed-off-by: Felipe Contreras
>>> ---
>>> builtin/fast-export.c | 24
>>> 1 file changed, 12 insertions(+), 12 deletio
John Szakmeister writes:
> On Wed, May 8, 2013 at 9:16 PM, Felipe Contreras
> wrote:
>> Signed-off-by: Felipe Contreras
>> ---
>> builtin/fast-export.c | 24
>> 1 file changed, 12 insertions(+), 12 deletions(-)
>>
>> diff --git a/builtin/fast-export.c b/builtin/fast-ex
On Thu, May 9, 2013 at 1:38 PM, Junio C Hamano wrote:
> Felipe Contreras writes:
>
if (!author)
- die ("Could not find author in commit %s",
+ die("Could not find author in commit %s",
sha1_to_hex(commit->object.sha1));
Felipe Contreras writes:
>>> if (!author)
>>> - die ("Could not find author in commit %s",
>>> + die("Could not find author in commit %s",
>>> sha1_to_hex(commit->object.sha1));
>>
>> It looks like your simple replace didn't account for cal
On Thu, May 9, 2013 at 5:24 AM, Ramkumar Ramachandra wrote:
> Felipe Contreras wrote:
>> AFAIK neither the git or the Linux code-style specify how multiple
>> lines with open parenthesis should align.
>
> git style inherits from linux style. See Chapter 9 of
> Documentation/CodingStyle in linux.g
Felipe Contreras wrote:
> AFAIK neither the git or the Linux code-style specify how multiple
> lines with open parenthesis should align.
git style inherits from linux style. See Chapter 9 of
Documentation/CodingStyle in linux.git. It has elisp snippets you can
stick in your .emacs.
--
To unsubsc
On Thu, May 9, 2013 at 4:30 AM, John Szakmeister wrote:
> On Thu, May 9, 2013 at 4:50 AM, Felipe Contreras
> wrote:
>> On Thu, May 9, 2013 at 3:46 AM, John Szakmeister
>> wrote:
>>> On Wed, May 8, 2013 at 9:16 PM, Felipe Contreras
> [snip]
@@ -289,13 +289,13 @@ static void handle_commit(st
On Thu, May 9, 2013 at 4:50 AM, Felipe Contreras
wrote:
> On Thu, May 9, 2013 at 3:46 AM, John Szakmeister wrote:
>> On Wed, May 8, 2013 at 9:16 PM, Felipe Contreras
[snip]
>>> @@ -289,13 +289,13 @@ static void handle_commit(struct commit *commit,
>>> struct rev_info *rev)
>>> parse_comm
On Thu, May 9, 2013 at 3:46 AM, John Szakmeister wrote:
> On Wed, May 8, 2013 at 9:16 PM, Felipe Contreras
> wrote:
>> Signed-off-by: Felipe Contreras
>> ---
>> builtin/fast-export.c | 24
>> 1 file changed, 12 insertions(+), 12 deletions(-)
>>
>> diff --git a/builtin/f
On Wed, May 8, 2013 at 9:16 PM, Felipe Contreras
wrote:
> Signed-off-by: Felipe Contreras
> ---
> builtin/fast-export.c | 24
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/builtin/fast-export.c b/builtin/fast-export.c
> index d60d675..8091354 10064
Signed-off-by: Felipe Contreras
---
builtin/fast-export.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/builtin/fast-export.c b/builtin/fast-export.c
index d60d675..8091354 100644
--- a/builtin/fast-export.c
+++ b/builtin/fast-export.c
@@ -135,7 +1
28 matches
Mail list logo
