Re: [PATCH 3/6] completion: add common options for blame

2013-06-06 Thread Peter Krefting
Ramkumar Ramachandra: Yeah. We generally prefer the long-form equivalents while doing completions, but these blame options do not have equivalent long-forms. Perhaps that is the real bug, then. -M and -C already have long names for diff (and its friends), perhaps blame should have the same

Re: [PATCH 3/6] completion: add common options for blame

2013-06-03 Thread Thomas Rast
Ramkumar Ramachandra artag...@gmail.com writes: Add support for completing 'git blame'. List only the common short options. [...] +_git_blame () +{ + __git_has_doubledash return + + case $cur in + -*) + __gitcomp -M -C -L -s -w + esac +

Re: [PATCH 3/6] completion: add common options for blame

2013-06-03 Thread Ramkumar Ramachandra
Thomas Rast wrote: Is this the first time we introduce completion (I guess you could call it help) for short options? I only did a quick search for /-. -/ but it certainly seems that way. Yeah. We generally prefer the long-form equivalents while doing completions, but these blame options do

Re: [PATCH 3/6] completion: add common options for blame

2013-06-03 Thread Junio C Hamano
Thomas Rast tr...@inf.ethz.ch writes: Ramkumar Ramachandra artag...@gmail.com writes: Add support for completing 'git blame'. List only the common short options. [...] +_git_blame () +{ +__git_has_doubledash return + +case $cur in +-*) +__gitcomp -M -C -L -s

Re: [PATCH 3/6] completion: add common options for blame

2013-06-03 Thread SZEDER Gábor
On Mon, Jun 03, 2013 at 03:02:00PM +0530, Ramkumar Ramachandra wrote: Thomas Rast wrote: Is this the first time we introduce completion (I guess you could call it help) for short options? I only did a quick search for /-. -/ but it certainly seems that way. Yeah. We generally prefer

Re: [PATCH 3/6] completion: add common options for blame

2013-06-03 Thread Junio C Hamano
SZEDER Gábor sze...@ira.uka.de writes: But providing short options for completion is pointless. Those who know git blame's short options will just type them right away, because it requires less key presses than using completion, and those who don't know these options will only see -C, -M,

[PATCH 3/6] completion: add common options for blame

2013-06-02 Thread Ramkumar Ramachandra
Add support for completing 'git blame'. List only the common short options. Signed-off-by: Ramkumar Ramachandra artag...@gmail.com --- contrib/completion/git-completion.bash | 11 +++ 1 file changed, 11 insertions(+) diff --git a/contrib/completion/git-completion.bash