Re: [PATCH 3/8] push tests: add more testing for forced tag pushing

2018-05-08 Thread Kaartic Sivaraam
On Monday 30 April 2018 01:50 AM, Ævar Arnfjörð Bjarmason wrote: > diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh > index 15c8d5a734..c9a2011915 100755 > --- a/t/t5516-fetch-push.sh > +++ b/t/t5516-fetch-push.sh > @@ -981,7 +981,17 @@ test_expect_success 'push requires --force to

Re: [PATCH 3/8] push tests: add more testing for forced tag pushing

2018-05-08 Thread Kaartic Sivaraam
On Tuesday 08 May 2018 08:49 AM, Junio C Hamano wrote: > Junio C Hamano writes: > >> I couldn't quite get what you meant by "(but not the other way >> around)". Did you mean >> >> $ git push --force ../child2 refs/tags/*:refs/tags/* >> >> should not become non-forcing

Re: [PATCH 3/8] push tests: add more testing for forced tag pushing

2018-05-07 Thread Junio C Hamano
Junio C Hamano writes: > I couldn't quite get what you meant by "(but not the other way > around)". Did you mean > > $ git push --force ../child2 refs/tags/*:refs/tags/* > > should not become non-forcing version because of the (lack of) > prefix on the refspec does not

Re: [PATCH 3/8] push tests: add more testing for forced tag pushing

2018-05-07 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Improve the tests added in dbfeddb12e ("push: require force for refs > under refs/tags/", 2012-11-29) to assert that the same behavior > applies various forms other refspecs, and that "+" in a refspec will > override the "--no-force" option

Re: [PATCH 3/8] push tests: add more testing for forced tag pushing

2018-05-07 Thread Kaartic Sivaraam
Hi, On Monday 30 April 2018 01:50 AM, Ævar Arnfjörð Bjarmason wrote: > diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh > index 15c8d5a734..c9a2011915 100755 > --- a/t/t5516-fetch-push.sh > +++ b/t/t5516-fetch-push.sh > @@ -981,7 +981,17 @@ test_expect_success 'push requires --force to

[PATCH 3/8] push tests: add more testing for forced tag pushing

2018-04-29 Thread Ævar Arnfjörð Bjarmason
Improve the tests added in dbfeddb12e ("push: require force for refs under refs/tags/", 2012-11-29) to assert that the same behavior applies various forms other refspecs, and that "+" in a refspec will override the "--no-force" option (but not the other way around). Signed-off-by: Ævar Arnfjörð