[PATCH 4/4] revision: convert to using diff_tree_sha1()

2014-02-05 Thread Kirill Smelkov
Since diff_tree_sha1() can now accept empty trees via NULL sha1, we could just call it without manually reading trees into tree_desc and duplicating code. Besides, that if (!tree) return 0; looked suspect - we were saying an invalid tree != empty tree, but maybe it is

Re: [PATCH 4/4] revision: convert to using diff_tree_sha1()

2014-02-05 Thread Jeff King
On Wed, Feb 05, 2014 at 08:57:12PM +0400, Kirill Smelkov wrote: Since diff_tree_sha1() can now accept empty trees via NULL sha1, we could just call it without manually reading trees into tree_desc and duplicating code. Besides, that if (!tree) return 0; looked