Re: [PATCH 4/4] shallow.c: remove useless test

2016-12-05 Thread Duy Nguyen
On Sat, Dec 3, 2016 at 12:24 PM, Jeff King wrote: > On Fri, Dec 02, 2016 at 09:31:04PM +0100, Rasmus Villemoes wrote: > >> It seems to be odd to do x=y if x==y. Maybe there's a bug somewhere near >> this, but as is this is somewhat confusing. > > Yeah, this code is definitely

Re: [PATCH 4/4] shallow.c: remove useless test

2016-12-02 Thread Jeff King
On Fri, Dec 02, 2016 at 09:31:04PM +0100, Rasmus Villemoes wrote: > It seems to be odd to do x=y if x==y. Maybe there's a bug somewhere near > this, but as is this is somewhat confusing. Yeah, this code is definitely wrong, but I'm not sure what it's trying to do. This is the first time I've

[PATCH 4/4] shallow.c: remove useless test

2016-12-02 Thread Rasmus Villemoes
It seems to be odd to do x=y if x==y. Maybe there's a bug somewhere near this, but as is this is somewhat confusing. Signed-off-by: Rasmus Villemoes --- shallow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shallow.c b/shallow.c index