Re: [PATCH 4/6] add -u: only show pathless 'add -u' warning when changes exist outside cwd

2013-03-20 Thread Junio C Hamano
Jonathan Nieder jrnie...@gmail.com writes: A common workflow in large projects is to chdir into a subdirectory of interest and only do work there: cd src vi foo.c make test git add -u git commit The upcoming change to 'git add -u' behavior would not affect

[PATCH 4/6] add -u: only show pathless 'add -u' warning when changes exist outside cwd

2013-03-19 Thread Jonathan Nieder
A common workflow in large projects is to chdir into a subdirectory of interest and only do work there: cd src vi foo.c make test git add -u git commit The upcoming change to 'git add -u' behavior would not affect such a workflow: when the only changes

Re: [PATCH 4/6] add -u: only show pathless 'add -u' warning when changes exist outside cwd

2013-03-19 Thread Jeff King
On Tue, Mar 19, 2013 at 03:50:50PM -0700, Jonathan Nieder wrote: This is the interesting one. [...] * summarized Peff's review with an Ack. I hope that's ok. Yeah, OK with me. I certainly agree with the intent, and I think your reasoning on the performance change is valid. I don't see