[PATCH 4/8] rebase: prepare to do generic housekeeping

2013-05-10 Thread Ramkumar Ramachandra
On successful completion of a rebase in git-rebase--$backend.sh, the $backend script cleans up on its own and exits. The cleanup routine is however, independent of the $backend, and each $backend script unnecessarily duplicates this work: rm -rf $state_dir git gc --auto Prepare

Re: [PATCH 4/8] rebase: prepare to do generic housekeeping

2013-05-10 Thread Eric Sunshine
On Fri, May 10, 2013 at 10:26 AM, Ramkumar Ramachandra artag...@gmail.com wrote: On successful completion of a rebase in git-rebase--$backend.sh, the $backend script cleans up on its own and exits. The cleanup routine is however, independent of the $backend, and each $backend script

Re: [PATCH 4/8] rebase: prepare to do generic housekeeping

2013-05-10 Thread Junio C Hamano
Eric Sunshine sunsh...@sunshineco.com writes: On Fri, May 10, 2013 at 10:26 AM, Ramkumar Ramachandra artag...@gmail.com wrote: On successful completion of a rebase in git-rebase--$backend.sh, the $backend script cleans up on its own and exits. The cleanup routine is however, independent of

Re: [PATCH 4/8] rebase: prepare to do generic housekeeping

2013-05-10 Thread Junio C Hamano
Ramkumar Ramachandra artag...@gmail.com writes: On successful completion of a rebase in git-rebase--$backend.sh, the $backend script cleans up on its own and exits. The cleanup routine is however, independent of the $backend, and each $backend script unnecessarily duplicates this work:

Re: [PATCH 4/8] rebase: prepare to do generic housekeeping

2013-05-10 Thread Ramkumar Ramachandra
Junio C Hamano wrote: So it is either (1) the added code is unreachable and unexercised at this point in the series, or Yeah, it's (1). Perhaps this should come a bit later in the series? When exactly? I picked up on your suggestion to separate out the preparation-for-$backend-to-return