Re: [PATCH 5/5] completion: fix completion of certain aliases

2014-04-18 Thread Felipe Contreras
Junio C Hamano wrote: > Gábor Szeder writes: > > > words[] is just fine, we never modify it after it is filled by > > _get_comp_words_by_ref() at the very beginning. > > Hmph. I would have understood if the latter were "we never look at > it (to decide what to do)". "we never modify it" does n

Re: [PATCH 5/5] completion: fix completion of certain aliases

2014-04-14 Thread Junio C Hamano
Gábor Szeder writes: > words[] is just fine, we never modify it after it is filled by > _get_comp_words_by_ref() at the very beginning. Hmph. I would have understood if the latter were "we never look at it (to decide what to do)". "we never modify it" does not sound like an enough justificatio

Re: [PATCH 5/5] completion: fix completion of certain aliases

2014-04-13 Thread Gábor Szeder
Hi, [I'm travelling, so I don't have the means to actually try out this patch, and it might take a while a to reply to any follow ups.] On Apr 10, 2014 12:03 AM, Junio C Hamano wrote: > > Felipe Contreras writes: > > > Some commands need the first word to determine the actual action that is

Re: [PATCH 5/5] completion: fix completion of certain aliases

2014-04-09 Thread Felipe Contreras
Junio C Hamano wrote: > Felipe Contreras writes: > > > Some commands need the first word to determine the actual action that is > > being executed, however, the command is wrong when we use an alias, for > > example 'alias.p=push', if we try to complete 'git p origin ', the > > result would be wr

Re: [PATCH 5/5] completion: fix completion of certain aliases

2014-04-09 Thread Junio C Hamano
Felipe Contreras writes: > Some commands need the first word to determine the actual action that is > being executed, however, the command is wrong when we use an alias, for > example 'alias.p=push', if we try to complete 'git p origin ', the > result would be wrong because __git_complete_remote_

[PATCH 5/5] completion: fix completion of certain aliases

2014-04-09 Thread Felipe Contreras
Some commands need the first word to determine the actual action that is being executed, however, the command is wrong when we use an alias, for example 'alias.p=push', if we try to complete 'git p origin ', the result would be wrong because __git_complete_remote_or_refspec() doesn't know where it