Re: [PATCH 5/5] versioncmp: cope with common leading parts in versionsort.prereleaseSuffix

2016-10-05 Thread Duy Nguyen
On Thu, Oct 6, 2016 at 7:40 AM, Jacob Keller wrote: > On Wed, Oct 5, 2016 at 3:15 PM, Junio C Hamano wrote: >> SZEDER Gábor writes: >> >>> Gut feeling tells me that I should take this as a subtle >>> encouragement to look into adding

Re: [PATCH 5/5] versioncmp: cope with common leading parts in versionsort.prereleaseSuffix

2016-10-05 Thread Jacob Keller
On Wed, Oct 5, 2016 at 3:15 PM, Junio C Hamano wrote: > SZEDER Gábor writes: > >> Gut feeling tells me that I should take this as a subtle >> encouragement to look into adding 'versionsort.postreleasesuffix', >> shouldn't I ;) > > It is more like "this made

Re: [PATCH 5/5] versioncmp: cope with common leading parts in versionsort.prereleaseSuffix

2016-10-05 Thread Junio C Hamano
SZEDER Gábor writes: > Gut feeling tells me that I should take this as a subtle > encouragement to look into adding 'versionsort.postreleasesuffix', > shouldn't I ;) It is more like "this made me realize that these are merely 'suffix' after the real release name, no pre- or

Re: [PATCH 5/5] versioncmp: cope with common leading parts in versionsort.prereleaseSuffix

2016-10-05 Thread SZEDER Gábor
Quoting Junio C Hamano : SZEDER Gábor writes: And a final sidenote: sorting based on the longest matching suffix also allows us to (ab)use version sort with prerelease suffixes to sort postrelease tags as we please, too: $ ~/src/git/git -c

Re: [PATCH 5/5] versioncmp: cope with common leading parts in versionsort.prereleaseSuffix

2016-10-05 Thread Junio C Hamano
SZEDER Gábor writes: > And a final sidenote: sorting based on the longest matching suffix > also allows us to (ab)use version sort with prerelease suffixes to > sort postrelease tags as we please, too: > > $ ~/src/git/git -c versionsort.prereleasesuffix=-alpha \ >

Re: [PATCH 5/5] versioncmp: cope with common leading parts in versionsort.prereleaseSuffix

2016-10-04 Thread SZEDER Gábor
Quoting SZEDER Gábor : Quoting SZEDER Gábor : Version sort with prerelease reordering sometimes puts tagnames in the wrong order, when the common part of two compared tagnames ends with the leading character(s) of one or more configured prerelease

Re: [PATCH 5/5] versioncmp: cope with common leading parts in versionsort.prereleaseSuffix

2016-09-09 Thread Duy Nguyen
On Wed, Sep 7, 2016 at 10:48 PM, SZEDER Gábor wrote: > Now, while I believe this is the right thing to do to fix this bug, > there is a corner case, where multiple configured prerelease suffixes > might match the same tagname: > > $ git config --get-all

Re: [PATCH 5/5] versioncmp: cope with common leading parts in versionsort.prereleaseSuffix

2016-09-07 Thread SZEDER Gábor
Quoting SZEDER Gábor : Version sort with prerelease reordering sometimes puts tagnames in the wrong order, when the common part of two compared tagnames ends with the leading character(s) of one or more configured prerelease suffixes. $ git config --get-all

[PATCH 5/5] versioncmp: cope with common leading parts in versionsort.prereleaseSuffix

2016-09-07 Thread SZEDER Gábor
Version sort with prerelease reordering sometimes puts tagnames in the wrong order, when the common part of two compared tagnames ends with the leading character(s) of one or more configured prerelease suffixes. $ git config --get-all versionsort.prereleaseSuffix -beta $ git tag -l