Re: [PATCH v1] Git config cache & special querying api utilizing the cache

2014-06-11 Thread Matthieu Moy
Tanay Abhra writes: > I have run the tests and debug the code using custom functions and it works > fine. I understand that you wrote the custom functions for you, but didn't include them in the patch, right? If so, wouldn't it make sense to include these as unit-tests for your code? See what G

[PATCH v1] Git config cache & special querying api utilizing the cache

2014-06-09 Thread Tanay Abhra
Hi, I am taking this patch out of RFC. [PATCH V1]:Most of the invaluable suggestions by Eric Sunshine, Torsten Bogershausen and Jeff King has been implemented[1]. Complete rewrite of config_cache*() family using git_config() as hook as suggested by Jeff. Thanks for the review.