Re: [PATCH v1 0/4] Teach 'run' perf script to read config files

On Wed, Jul 26, 2017 at 05:58:09PM +0200, Christian Couder wrote: > Actually after taking another look at that, it looks like the following > happens: > > 1) the run script sources the original GIT-BUILD-OPTIONS file from > ../.. relative to its location > 2) a git version is built in

Re: [PATCH v1 0/4] Teach 'run' perf script to read config files

On Fri, Jul 14, 2017 at 8:27 AM, Christian Couder wrote: > On Thu, Jul 13, 2017 at 10:55 PM, Jeff King wrote: >> On Thu, Jul 13, 2017 at 08:57:01PM +0200, Christian Couder wrote: >> >>> >> We want to make it possible to store the parameters to the 'run'

Re: [PATCH v1 0/4] Teach 'run' perf script to read config files

On Fri, Jul 14, 2017 at 08:27:53AM +0200, Christian Couder wrote: > The whole thing seems really complex to me though. And this makes me > think that people might want to specify different GIT-BUILD-OPTIONS > and config.mak files to be used when running perf tests, so that the > results from perf

Re: [PATCH v1 0/4] Teach 'run' perf script to read config files

On Thu, Jul 13, 2017 at 10:55 PM, Jeff King wrote: > On Thu, Jul 13, 2017 at 08:57:01PM +0200, Christian Couder wrote: > >> >> We want to make it possible to store the parameters to the 'run' >> >> script in a config file. This will make it easier to store, reuse, >> >> share and

Re: [PATCH v1 0/4] Teach 'run' perf script to read config files

On Thu, Jul 13, 2017 at 08:57:01PM +0200, Christian Couder wrote: > >> We want to make it possible to store the parameters to the 'run' > >> script in a config file. This will make it easier to store, reuse, > >> share and compare parameters. > > > > Because perf-lib is built on test-lib, it

Re: [PATCH v1 0/4] Teach 'run' perf script to read config files

On Thu, Jul 13, 2017 at 8:40 PM, Jeff King wrote: > On Thu, Jul 13, 2017 at 11:29:10AM -0700, Junio C Hamano wrote: > >> > So then I think your config file primarily becomes about defining the >> > properties of each run. I'm not sure if it would look like what you're >> > starting

Re: [PATCH v1 0/4] Teach 'run' perf script to read config files

Jeff King writes: > ... But if > we did have a third-party system, I suspect the interesting work would > be setting up profiles for the "run" tool to kick off. And we might be > stuck in such a case using whatever format the tool prefers. So having a > sense of what the final

Re: [PATCH v1 0/4] Teach 'run' perf script to read config files

On Thu, Jul 13, 2017 at 6:58 PM, Jeff King wrote: > On Thu, Jul 13, 2017 at 08:50:46AM +0200, Christian Couder wrote: > >> Goal >> >> >> Using many long environment variables to give parameters to the 'run' >> script is error prone and tiring. >> >> We want to make it possible

Re: [PATCH v1 0/4] Teach 'run' perf script to read config files

On Thu, Jul 13, 2017 at 11:29:10AM -0700, Junio C Hamano wrote: > > So then I think your config file primarily becomes about defining the > > properties of each run. I'm not sure if it would look like what you're > > starting on here or not. > > Yeah, I suspect that the final shape that defines

Re: [PATCH v1 0/4] Teach 'run' perf script to read config files

Jeff King writes: > Because perf-lib is built on test-lib, it already reads > GIT-BUILD-OPTIONS. And the Makefile copies several perf-related values > into it, including GIT_PERF_MAKE_OPTS and GIT_PERF_REPEAT_COUNT. So you > can already do: > ... > But right now the perf suite is

Re: [PATCH v1 0/4] Teach 'run' perf script to read config files

On Thu, Jul 13, 2017 at 08:50:46AM +0200, Christian Couder wrote: > Goal > > > Using many long environment variables to give parameters to the 'run' > script is error prone and tiring. > > We want to make it possible to store the parameters to the 'run' > script in a config file. This will

[PATCH v1 0/4] Teach 'run' perf script to read config files

Goal Using many long environment variables to give parameters to the 'run' script is error prone and tiring. We want to make it possible to store the parameters to the 'run' script in a config file. This will make it easier to store, reuse, share and compare parameters. In the future it