Re: [PATCH v1 05/19] update-index: warn in case of split-index incoherency

2016-11-01 Thread Junio C Hamano
Christian Couder writes: >>> Wrap this string and the one below with _() so they can be translated. >> >> True. >> >> I further wonder if a natural reaction from users after seeing this >> message is "I do want to--what else would I use that option to run >> you for?

Re: [PATCH v1 05/19] update-index: warn in case of split-index incoherency

2016-11-01 Thread Christian Couder
On Tue, Nov 1, 2016 at 8:05 PM, Junio C Hamano wrote: > Duy Nguyen writes: > >>> diff --git a/builtin/update-index.c b/builtin/update-index.c >>> index b75ea03..a14dbf2 100644 >>> --- a/builtin/update-index.c >>> +++ b/builtin/update-index.c >>> @@ -1098,12

Re: [PATCH v1 05/19] update-index: warn in case of split-index incoherency

2016-11-01 Thread Junio C Hamano
Duy Nguyen writes: >> diff --git a/builtin/update-index.c b/builtin/update-index.c >> index b75ea03..a14dbf2 100644 >> --- a/builtin/update-index.c >> +++ b/builtin/update-index.c >> @@ -1098,12 +1098,21 @@ int cmd_update_index(int argc, const char **argv, >> const char

Re: [PATCH v1 05/19] update-index: warn in case of split-index incoherency

2016-10-29 Thread Christian Couder
On Tue, Oct 25, 2016 at 12:00 PM, Duy Nguyen wrote: > On Sun, Oct 23, 2016 at 4:26 PM, Christian Couder > wrote: >> When users are using `git update-index --(no-)split-index`, they >> may expect the split-index feature to be used or not according to

Re: [PATCH v1 05/19] update-index: warn in case of split-index incoherency

2016-10-25 Thread Duy Nguyen
On Sun, Oct 23, 2016 at 4:26 PM, Christian Couder wrote: > When users are using `git update-index --(no-)split-index`, they > may expect the split-index feature to be used or not according to > the option they just used, but this might not be the case if the > new

[PATCH v1 05/19] update-index: warn in case of split-index incoherency

2016-10-23 Thread Christian Couder
When users are using `git update-index --(no-)split-index`, they may expect the split-index feature to be used or not according to the option they just used, but this might not be the case if the new "core.splitIndex" config variable has been set. In this case let's warn about what will happen and