Re: [PATCH v1 2/3] convert: modernize tests

On Tue, Jul 26, 2016 at 8:18 AM, Remi Galan Alfonso wrote: > Considering how close it is to your patch, you might also want to > remove spaces after '<'. > > There is only one occurrence in this file and it's in a line you are > already modifying. Good

Re: [PATCH v1 2/3] convert: modernize tests

Hi Lars, Sorry, minor nit that I noticed a couple of days ago but didn't comment on the moment and forgot until now. Lars Schneider wrote: > Use `test_config` to set the config, check that files are empty with > `test_must_be_empty`, compare files with `test_cmp`, and

[PATCH v1 2/3] convert: modernize tests

From: Lars Schneider Use `test_config` to set the config, check that files are empty with `test_must_be_empty`, compare files with `test_cmp`, and remove spaces after ">". Signed-off-by: Lars Schneider --- t/t0021-conversion.sh | 62