Re: [PATCH v1.1 1/2] t9400-git-cvsserver-server: don't rely on the output of 'test_cmp'

On Fri, Mar 9, 2018 at 12:44 AM, Junio C Hamano wrote: > SZEDER Gábor writes: >>> This makes "rm -f failures &&" unnecessary, no? >> >> Indeed, it does. > > OK, no need to resend, as I'll amend it locally before queuing > (unless there is something else

Re: [PATCH v1.1 1/2] t9400-git-cvsserver-server: don't rely on the output of 'test_cmp'

SZEDER Gábor writes: > On Fri, Mar 9, 2018 at 12:33 AM, Junio C Hamano wrote: >> SZEDER Gábor writes: >> >>> diff --git a/t/t9400-git-cvsserver-server.sh >>> b/t/t9400-git-cvsserver-server.sh >>> index c30660d606..5ff3789199

Re: [PATCH v1.1 1/2] t9400-git-cvsserver-server: don't rely on the output of 'test_cmp'

On Fri, Mar 9, 2018 at 12:33 AM, Junio C Hamano wrote: > SZEDER Gábor writes: > >> diff --git a/t/t9400-git-cvsserver-server.sh >> b/t/t9400-git-cvsserver-server.sh >> index c30660d606..5ff3789199 100755 >> --- a/t/t9400-git-cvsserver-server.sh >> +++

Re: [PATCH v1.1 1/2] t9400-git-cvsserver-server: don't rely on the output of 'test_cmp'

SZEDER Gábor writes: > diff --git a/t/t9400-git-cvsserver-server.sh b/t/t9400-git-cvsserver-server.sh > index c30660d606..5ff3789199 100755 > --- a/t/t9400-git-cvsserver-server.sh > +++ b/t/t9400-git-cvsserver-server.sh > @@ -449,10 +449,9 @@ test_expect_success 'cvs update

[PATCH v1.1 1/2] t9400-git-cvsserver-server: don't rely on the output of 'test_cmp'

The test 'cvs update (-p)' redirects and checks 'test_cmp's stdout and even its stderr. The commit introducing this test in 6e8937a084 (cvsserver: Add test for update -p, 2008-03-27) doesn't discuss why, in fact its log message only consists of that subject line. Anyway, weird as it is, it kind